Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .configuration and .page_build? methods to Pages #89

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Add .configuration and .page_build? methods to Pages #89

merged 2 commits into from
Jan 24, 2017

Conversation

parkr
Copy link
Member

@parkr parkr commented Jan 24, 2017

.configuration gives us a way to debug our metadata fetching by showing what the Pages configuration is.

.page_build? gives us a different way to enable automatically setting the site.url and site.baseurl values when running in development mode.

/cc @jldec

@parkr parkr requested review from benbalter and jldec January 24, 2017 17:04
jldec
jldec approved these changes Jan 24, 2017
View reviewed changes
Copy link

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks - that's helpful.

@parkr
Copy link
Member Author

parkr commented Jan 24, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit a9e1026 into master Jan 24, 2017
@jekyllbot jekyllbot deleted the configuration-for-dev branch January 24, 2017 17:42
jekyllbot added a commit that referenced this pull request Jan 24, 2017
@jekyllbot
Update history to reflect merge of #89 [ci skip]
8906f2b
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jldec jldec jldec approved these changes

@benbalter benbalter Awaiting requested review from benbalter

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parkr @jldec @jekyllbot