Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site.github.environment should be the same as site.github.pages_env #36

Merged
merged 2 commits into from
Mar 2, 2016
Merged

site.github.environment should be the same as site.github.pages_env #36

merged 2 commits into from
Mar 2, 2016

Conversation

parkr
Copy link
Member

@parkr parkr commented Mar 2, 2016

It should be dotcom, not production, for example.

parkr added a commit that referenced this pull request Mar 2, 2016
@parkr
Merge pull request #36 from jekyll/set-environment-to-pages-env
3b90d0d 
site.github.environment should be the same as site.github.pages_env
@parkr parkr merged commit 3b90d0d into master Mar 2, 2016
@parkr parkr deleted the set-environment-to-pages-env branch March 2, 2016 19:55
parkr added a commit that referenced this pull request Mar 2, 2016
@parkr
Update history to reflect resolution of #36 [ci skip]
fb4d3e3
@jekyll jekyll locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parkr @jekyllbot