Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Repository#url_scheme for the pages URL scheme. #35

Merged
merged 3 commits into from
Mar 2, 2016
Merged

Add Repository#url_scheme for the pages URL scheme. #35

merged 3 commits into from
Mar 2, 2016

Conversation

parkr
Copy link
Member

@parkr parkr commented Mar 1, 2016

Fixes #33.

/cc @benbalter

@parkr parkr added the bug label Mar 1, 2016
@parkr parkr mentioned this pull request Mar 1, 2016
Closed
@benbalter
Copy link
Contributor

Odd that 1/5 tests failed? Otherwise, LGTM (unless you want to put scheme on the repository).

@parkr parkr changed the title *.github.jparrowsec.cn pages URL's should be HTTPS'd Add Repository#scheme for the pages URL scheme. Mar 2, 2016
@parkr
Repository#scheme ~> Repository#url_scheme
ad133c2 
This makes it more specifically about the URL and not about the repo URL or
something.

... maybe #pages_url_scheme would have been better.
@parkr parkr changed the title Add Repository#scheme for the pages URL scheme. Add Repository#url_scheme for the pages URL scheme. Mar 2, 2016
parkr added a commit that referenced this pull request Mar 2, 2016
@parkr
Merge pull request #35 from jekyll/force-https-for-github-urls
c21c9f4 
Add Repository#url_scheme for the pages URL scheme.
@parkr parkr merged commit c21c9f4 into master Mar 2, 2016
@parkr parkr deleted the force-https-for-github-urls branch March 2, 2016 19:40
parkr added a commit that referenced this pull request Mar 2, 2016
@parkr
Update history to reflect resolution of #35 [ci skip]
998c351
@jekyll jekyll locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*.github.jparrowsec.cn domains should have a HTTPS scheme, not HTTP
3 participants
@parkr @benbalter @jekyllbot