Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add dev docs #212

Merged
merged 9 commits into from
Jan 27, 2022
Merged

docs: Add dev docs #212

merged 9 commits into from
Jan 27, 2022

Conversation

MichaelCurrin
Copy link
Contributor

Fixes #206

lardieri
lardieri suggested changes Aug 3, 2021
View reviewed changes
MichaelCurrin
MichaelCurrin commented Aug 3, 2021
View reviewed changes
MichaelCurrin
MichaelCurrin commented Aug 3, 2021
View reviewed changes
@MichaelCurrin
Copy link
Contributor Author

Thanks for suggestions. I've applied and also fixed up the headings (I'm using to having H1 with H2s below, so had to fix it up to have one H2 and multiple H3s to match other docs).

@lardieri
Copy link
Contributor

lardieri commented Aug 3, 2021

Thank you for writing this document. I wish I had had it when I started using GitHub Pages six months ago!

mattr-
mattr- requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small comments on this PR that I think should be addressed before merging. Thanks for taking a look!

@MichaelCurrin MichaelCurrin requested a review from mattr- August 4, 2021 10:49
mattr-
mattr- approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates!

@parkr
Copy link
Member

parkr commented Jan 27, 2022

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 1724d7f into jekyll:master Jan 27, 2022
jekyllbot added a commit that referenced this pull request Jan 27, 2022
@jekyllbot
Update history to reflect merge of #212 [ci skip]
7868d06
@MichaelCurrin MichaelCurrin deleted the docs-add-dev-docs branch January 31, 2022 10:30
@jekyll jekyll locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

@parkr parkr parkr approved these changes

@lardieri lardieri lardieri approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add developer docs
5 participants
@MichaelCurrin @lardieri @parkr @mattr- @jekyllbot