Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JEKYLL_ENV limitation for git remote #185

Merged
merged 1 commit into from
May 5, 2022

Conversation

at-ishikawa
Copy link
Contributor

Why

In order to find out the logic to configure NWO using git remote depends on JEKYLL_ENV easily.

What

I got the errors when I ran JEKYLL_ENV=production bundle exec jekyll serve for GitHub Pages.
The error is something like this.

  Liquid Exception: No repo name found. Specify using PAGES_REPO_NWO environment variables, 'repository' in your configuration, or set up an 'origin' git remote pointing to your github.com repository. in /_layouts/single.html
             ERROR: YOUR SITE COULD NOT BE BUILT:
                    ------------------------------------
                    No repo name found. Specify using PAGES_REPO_NWO environment variables, 'repository' in your configuration, or set up an 'origin' git remote pointing to your github.com repository.

When I checked this code, I figured out that git remote is only checked if JEKYLL_ENV is either of development or test from the below code.
https://github.com/jekyll/github-metadata/blob/master/lib/jekyll-github-metadata/repository_finder.rb#L63

By the way, I'm a beginner for ruby, jekyll, and github pages, so please let me know something is wrong.

Related issues

  • The comment from issue 91

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parkr
Copy link
Member

parkr commented May 5, 2022

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 285a60b into jekyll:main May 5, 2022
@jekyll jekyll locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants