Add JEKYLL_ENV limitation for git remote #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In order to find out the logic to configure NWO using
git remote
depends onJEKYLL_ENV
easily.What
I got the errors when I ran
JEKYLL_ENV=production bundle exec jekyll serve
for GitHub Pages.The error is something like this.
When I checked this code, I figured out that
git remote
is only checked ifJEKYLL_ENV
is either ofdevelopment
ortest
from the below code.https://github.com/jekyll/github-metadata/blob/master/lib/jekyll-github-metadata/repository_finder.rb#L63
By the way, I'm a beginner for ruby, jekyll, and github pages, so please let me know something is wrong.
Related issues