Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #173

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Fix test failures #173

merged 4 commits into from
Oct 23, 2019

Conversation

parkr
Copy link
Member

@parkr parkr commented Oct 2, 2019 •
edited
Loading

  • MetadataDrop: update mutations reference to use helper method
  • Lock rspec-expectations and rspec-mocks

@ashmaroli
Copy link
Member

@parkr Something seems to have changed with either the rspec-expectations gem or perhaps gem rspec-mocks, both of which saw a release couple of hours ago today.

I've pushed a commit to lock the versions of these gems from the last known passing build.

@ashmaroli ashmaroli requested review from benbalter and a team October 2, 2019 18:39
@benbalter benbalter merged commit 9353743 into master Oct 23, 2019
@benbalter benbalter deleted the fix-ci branch October 23, 2019 14:23
@jekyll jekyll locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parkr @ashmaroli @benbalter @jekyllbot