Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom head content #59

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

Arafo
Copy link
Contributor

@Arafo Arafo commented Aug 26, 2021

Just as simple as that, add support to include a custom-head.html file so you can add your own head content

Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arafo Thanks for the contribution, could you explain the advantage why we need another custom-head.html file rather than to change the head.html directly?

@Arafo
Copy link
Contributor Author

Arafo commented Aug 26, 2021

It's an easy way to add custom head code without changing head.html.

One potential use case, you installed the theme through Gemfile and now you want to add something new to the head section. Without a custom head file you have to add _layouts/head.html to your project overriding the file from this repo with the same content plus what you want to add.

That's a bit inconvenient as head.html content could change in the future if someone adds a new plugin to this theme and so, you have to update your head file in your own project.

Adding a way to include custom head content avoids this issue.

@jeffreytse jeffreytse merged commit 374690b into jeffreytse:master Aug 26, 2021
@jeffreytse
Copy link
Owner

@Arafo Thanks for the explaining. Hope you have a good day! : )

shahbaz22 pushed a commit to shahbaz22/resonance-site that referenced this pull request Nov 17, 2024
jnooree pushed a commit to jnooree/jnooree.github.io that referenced this pull request Feb 17, 2025
…e#59)

* remove dongyun kim

* add CSearch and modify some paper infos

* add Jaehyeong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants