-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-format copyright message and auto increase copyright end year based on the current year #46
Conversation
Hi @Anthonyive Firstly, thanks for the PR on auto updating the copyright period. For the year of copyright, I don't recommend to use a third-party gem, could you refactor it and implement it by the placeholder parameter? For example: copyright: "(c)copyright 2017-{currentYear}" Thanks and regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implement of auto increasing copyright period on the current year should be better simplified.
@jeffreytse I will remove that gem. That gem was not used for the code. It was just for the local server to work properly since I was using ruby 3.0 |
Thanks for the suggestions! I will look into them. |
bb3811d
to
23e8c7f
Compare
New implementation based on copyright.gov: Write copyright: "Unpublished Work (cleft) 2017-{currentYear} {author}"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, and this implement has almost reached the goal.
This comment is crucial, especially for newcomers.
* feat: re-format copyright message and auto increase current year * docs: add comment for copyright setting This comment is crucial, especially for newcomers. * refactor: better liquid code format Co-authored-by: jeffreytse <[email protected]>
Simple explanation: