Fix footer/menu popup colours #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreytse
reviewed
May 17, 2021
When the body content is less, the footer background colour should be transparent.
shahbaz22
pushed a commit
to shahbaz22/resonance-site
that referenced
this pull request
Nov 17, 2024
* Fix footer/menu popup colours * fix: correct the footer background colour When the body content is less, the footer background colour should be transparent. Co-authored-by: JT <[email protected]>
jnooree
pushed a commit
to jnooree/jnooree.github.io
that referenced
this pull request
Feb 17, 2025
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 3 to 4. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v3...v4) [skip ci] --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a dark theme colour (coolblack; spacegrey):
This fix aims to solve these two issues.
CSS is NOT my thing, and I don't know your intention using
unsetandtransparent- but this change at least appears correct.Thanks for the theme - it's sooo good!