Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video banner auto playing is not working in Safari #47

Closed
jeffreytse opened this issue Jun 27, 2021 · 0 comments
Closed

Video banner auto playing is not working in Safari #47

jeffreytse opened this issue Jun 27, 2021 · 0 comments
Assignees
@jeffreytse
Labels
bug Something isn't working verified This issue was already verified

Comments

@jeffreytse
Copy link
Owner

jeffreytse commented Jun 27, 2021 •
edited
Loading

For the Safari on OSX, as the default websites Auto-Play option is Stop Media with Sound, this strategy can also introduce the permission issue.

image

For the Safari on iPhone, the default websites Auto-Playoptions are not only Stop Media with Sound but also Stop Media with FullScreen.

To solve it, we should auto add muted and playsinline properties when this permission issue occurred. in case you get yourself confused about this property playsinline, here is the explaination.

Mobile browsers, playsinline will play the video right where it is instead of the default, which is to open it up fullscreen while it plays.
@jeffreytse jeffreytse self-assigned this Jun 27, 2021
@jeffreytse jeffreytse added bug Something isn't working verified This issue was already verified labels Jun 27, 2021
jeffreytse added a commit that referenced this issue Jun 27, 2021
@jeffreytse
fix: video banner is not working in Safari (#47)
6d4680a 
Auto add muted and playsinline properties when this permission
issue occurred.
shahbaz22 pushed a commit to shahbaz22/resonance-site that referenced this issue Nov 17, 2024
@jeffreytse
fix: video banner is not working in Safari (jeffreytse#47)
a54f51e 
Auto add muted and playsinline properties when this permission
issue occurred.
jnooree pushed a commit to jnooree/jnooree.github.io that referenced this issue Feb 17, 2025
@dependabot
chore(deps): bump rexml from 3.2.8 to 3.3.3 (jeffreytse#47)
bf53cc3 
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.3.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.8...v3.3.3)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreytse jeffreytse

Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffreytse