Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump #138

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Bump #138

merged 4 commits into from
Feb 3, 2025

Conversation

lishaduck
Copy link
Contributor

Resolves: #137.

Vite 6, Vitest 3, Rolldown 1.0 beta (off of nightly), TypeScript 5.7... and all it needed was a one-line change in the build config (I made 2 others, but they weren't necessary to get it running on tsdown 0.5).

@lishaduck
Copy link
Contributor Author

Huh. Can't repro locally. Will take a look tomorrow.

I did this yesterday, but there's a big enough diff we'll see if there was just a stale cache somewhere or something.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 100.0%. remained the same
when pulling 51b2bd0 on lishaduck:bump
into af484ca on jeffijoe:master.

@jeffijoe jeffijoe merged commit b4dc332 into jeffijoe:master Feb 3, 2025
5 checks passed
@jeffijoe
Copy link
Owner

jeffijoe commented Feb 3, 2025

Thanks @lishaduck , this PR has been released!

@lishaduck
Copy link
Contributor Author

lishaduck commented Feb 3, 2025

Thanks @lishaduck , this PR has been released!

I was gonna say it was just dev-time stuff and didn't actually need a release, but then I checked and new build shaves off 4kb... of a 10mg pkg, but 🤷‍♂️

@jeffijoe
Copy link
Owner

jeffijoe commented Feb 3, 2025

It's the little things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants