feat(store): add amd rx 6000 series model #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcbevans
changed the title
|
was this added? |
|
No, and the models have yet to be updated. |
|
The URL for the regular RX 6800 (non-XT) is https://www.amd.com/en/direct-buy/5458373400/us by the way. |
|
Looks great! Thanks for also sorting lexicographically! |
jef
previously approved these changes
Nov 18, 2020
|
Sorry about the linting. I need to make an update to the max columns. I don't like it being this short. |
This was referenced Nov 18, 2020
Closed
|
When will this be a feature we can get in a normal update? sorry sort of a noob... |
jef
approved these changes
Nov 19, 2020
jef
changed the title
|
6900xt link: https://www.amd.com/en/direct-buy/5458372200/us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AMD RX 6800/6800XT/6900XT to Series type. Extend .env-example with new MAX_PRICE config. Add AMD reference and Strix LC as model types. Add Sapphire as new brand.
Testing
Verified program runs without error. Tested that filtering series to new AMD series runs, albeit there are no product pages to check.