feat: Add More 50xx series, and add copy paste templates for adding more links #3191

Mr-Tech-13 · 2025-01-12T18:16:09Z

As stated in the title I added 50 series links for Bestbuy, Newegg, Pny, and Zotac. I also added some AMD CPUs. I also made copy paste templates at the bottom so it is easier to bulk add cards. The biggest thing was adding all of the Ubiquiti Switches, Cameras, Wifi, and Firewalls.

Enjoy!

JDIacobbo · 2025-01-16T21:16:07Z

I attempted to build this from the docker file to test it (read: run it early) and I am getting the following error when building the docker image:

[+] Building 8.5s (16/21)                                        docker:default
 => [internal] load build definition from Dockerfile                       0.0s
 => => transferring dockerfile: 1.10kB                                     0.0s
 => [internal] load metadata for docker.io/library/node:16.18.0-alpine3.1  0.2s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 94B                                           0.0s
 => [internal] load build context                                          0.0s
 => => transferring context: 767.79kB                                      0.0s
 => [builder  1/10] FROM docker.io/library/node:16.18.0-alpine3.16@sha256  0.0s
 => CACHED [stage-1 2/8] RUN apk add --no-cache chromium                   0.0s
 => CACHED [stage-1 3/8] RUN addgroup -S appuser && adduser -S -g appuser  0.0s
 => CACHED [stage-1 4/8] WORKDIR /app                                      0.0s
 => CACHED [builder  2/10] WORKDIR /build                                  0.0s
 => CACHED [builder  3/10] COPY package.json package.json                  0.0s
 => CACHED [builder  4/10] COPY package-lock.json package-lock.json        0.0s
 => CACHED [builder  5/10] COPY tsconfig.json tsconfig.json                0.0s
 => CACHED [builder  6/10] RUN npm ci                                      0.0s
 => CACHED [builder  7/10] COPY src/ src/                                  0.0s
 => CACHED [builder  8/10] COPY test/ test/                                0.0s
 => ERROR [builder  9/10] RUN npm run compile                              8.2s
------                                                                          
 > [builder  9/10] RUN npm run compile:                                         
0.580                                                                           
0.580 > [email protected] compile
0.580 > tsc
0.580 
7.821 src/store/lookup.ts:501:51 - error TS2551: Property 'ryzen7800x3d' does not exist on type '{ 3050: number; 3060: number; '3060ti': number; 3070: number; '3070ti': number; 3080: number; '3080ti': number; 3090: number; '4080-12g': number; '4080-16g': number; 4090: number; 5070: number; '5070ti': number; 5080: number; ... 26 more ...; xboxsx: number; }'. Did you mean 'ryzen9800x3d'?
7.821 
7.821 501     const maxPrice = config.store.maxPrice.series[link.series];
7.821                                                       ~~~~~~~~~~~
7.821 
7.822 
7.822 Found 1 error.
7.822 
------
Dockerfile:18
--------------------
  16 |     COPY src/ src/
  17 |     COPY test/ test/
  18 | >>> RUN npm run compile
  19 |     RUN npm prune --production
  20 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c npm run compile" did not complete successfully: exit code: 1

I have no issue building from jef's main branch.

Mr-Tech-13 · 2025-01-16T21:27:08Z

@JDIacobbo So sorry I mistyped something in the code.. I will update that right now

Mr-Tech-13 · 2025-01-16T21:42:11Z

Try Now? I may need to revamp my ubiquity changes

JDIacobbo · 2025-01-16T23:38:51Z

Still won't compile with the same error.

jef · 2025-01-17T01:01:11Z

Another absolute banger!!! Thank you 🙏 😍

jef · 2025-01-17T01:03:29Z

Looks like @JDIacobbo is right. Let me know if you need any help!

dotenv-example

src/store/model/newegg.ts

Fix bug

Mr-Tech-13 · 2025-01-18T22:50:16Z

@jef ok so I remove all my UI stuff because of a bug I found. I will make that a separate PR. However regarding the discrepancy with the 9600 vs non x version, I dont think the 5000 series differentiated the two which is why I did it the way I did. It should be good now

Mr-Tech-13 · 2025-01-18T22:51:04Z

@JDIacobbo I found and fixed the bug. see this

JDIacobbo · 2025-01-19T13:43:13Z

@JDIacobbo I found and fixed the bug. see this

Looks good to me. I was able to build and run the container.

P-Adamiec · 2025-01-22T15:09:59Z

I'm not really technical in programing, but in Poland the FE version is only available from NVIDIA store. Can you add links for it to work. I want to secure 5090 for work.

Mr-Tech-13 · 2025-01-22T15:11:45Z

@P-Adamiec sure. I'll try to get something working. Can you send me a link to the nvidia store page?

P-Adamiec · 2025-01-22T17:51:16Z

@Mr-Tech-13 https://marketplace.nvidia.com/pl-pl/consumer/graphics-cards/

P-Adamiec · 2025-01-22T19:23:00Z

@Mr-Tech-13 I'm going through 'Getting started' section and is there a way to include only this nvidia shop to constantly check one website instead of going around those that are listed OUT OF STOCK and increasing the time of checking my entry?

Mr-Tech-13 · 2025-01-22T19:24:59Z

Set STORES= to the store you want to scan

jef · 2025-01-29T20:44:12Z

Thanks @Mr-Tech-13! I just made a bunch of commits, so pull those in and then feel free to add the CA ones. After that, we'll run and merge!

Selectors are tested and working

Mr-Tech-13 · 2025-01-29T21:00:41Z

@jef All good to go. Just had to change config.ts to use 9600x instead of 9600 for the series. Did a test and everything is working as it should

jef · 2025-01-29T21:14:13Z

@jef All good to go. Just had to change config.ts to use 9600x instead of 9600 for the series. Did a test and everything is working as it should

Aha! Missed that 😅 Thanks for getting that fixed for me :)

jef

Amazing work @Mr-Tech-13. As always, I appreciate your support and contributions ❤️ People will be very happy!

🤖 I have created a release *beep* *boop* --- ## [3.10.0](v3.9.0...v3.10.0) (2025-01-29) ### Features * add 50xx series ([#3190](#3190)) ([db07796](db07796)) * add 50xx series discord notification groups ([#3193](#3193)) ([f59d3fc](f59d3fc)) * add more 50xx series, add templates for adding more links ([#3191](#3191)) ([ce6d084](ce6d084)) * add new microcenters locations, more 4090 GPUs, fixed incorrect URLs ([#3181](#3181)) ([218b0c3](218b0c3)) * add NTFY.SH agent ([#3195](#3195)) ([e18f231](e18f231)) ### Miscellaneous * update bestbuy selectors ([#3186](#3186)) ([810cefc](810cefc)) ### Continuous Integration * update pr linter ([25d556c](25d556c)) ### Documentation * remove badges ([4388e9a](4388e9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

thetallchap · 2025-01-30T00:13:53Z

There is not a way to get the links until they post them. You can guess at the links but I can't submit code knowing that it has a chance of not working

Many thanks for all your hard work on this. I'm looking at updating nvidia-gb for the 5080 / 5090 but obviously no links to work with from Nvidia's page. I'm manually modifying links from previous releases but understand you can't code those in if not confirmed and the chance of success doing that looks remote.

Mr-Tech-13 · 2025-01-30T00:20:01Z

I'm working on a pr for nvidia stores tomorrow once I can confirm the links

thetallchap · 2025-01-30T01:04:45Z

I'm working on a pr for nvidia stores tomorrow once I can confirm the links

You're a star, thank you for the incredible support.

alanbixby · 2025-01-30T02:09:44Z

@Mr-Tech-13

I'm working on a pr for nvidia stores tomorrow once I can confirm the links

Here is the add-to-cart HTML snippet for the 4060ti while it was still in stock on https://marketplace.nvidia.com/en-us/consumer/graphics-cards/. The last card sold out while I was looking into this, so I don't have a direct product page URL that isn't a 'Buy Now' external retailer page.

For the time being we might be able to make do with checking the list version of the site until someone gets a positive ID on what an add to cart looks like for the first party store.

<div
  _ngcontent-wox-c10=""
  aria-haspopup="true"
  tabindex="0"
  class="droplink product-details-grid-tile grid-tile-spacing nv-productTile"
>
  <!---->
  <div _ngcontent-wox-c10="" class="nv-tileTopRow">
    <div _ngcontent-wox-c10="" class="nv-bestSeller">Best Seller</div>
    <!----><!---->
  </div>
  <div
    _ngcontent-wox-c10=""
    style="
      position: relative;
      display: flex;
      flex-direction: column;
      height: 100%;
    "
  >
    <div
      _ngcontent-wox-c10=""
      class="product-details-image-container"
      style="align-self: center"
    >
      <!----><kui-image
        _ngcontent-wox-c10=""
        data-testid="kui-image"
        class="c-JRore"
        style="
          display: flex;
          background: transparent;
          visibility: visible;
          overflow: hidden;
        "
        ><img
          _ngcontent-wox-c10=""
          width="100%"
          height="100%"
          src="https://assets.nvidia.partners/images/png/GeForce-ADA-RTX4060Ti-Back.png"
          title="NVIDIA RTX 4060 Ti"
          alt="NVIDIA RTX 4060 Ti"
          data-pid-code="104138"
          data-ctatype="add_to_cart"
          data-producttitle="NVIDIA GeForce RTX 4060 Ti"
          class="nv-image"
          data-listener-added="true" /></kui-image
      ><!---->
    </div>
    <h2
      _ngcontent-wox-c10=""
      kuitext=""
      title="NVIDIA GeForce RTX 4060 Ti"
      data-pid-code="104138"
      data-ctatype="add_to_cart"
      data-producttitle="NVIDIA GeForce RTX 4060 Ti"
      class="nv-productTitle c-fOVUQc"
      data-testid="kui-text"
      data-listener-added="true"
    >
      NVIDIA GeForce RTX 4060 Ti
    </h2>
    <!----><!----><!---->
    <div
      _ngcontent-wox-c10=""
      class="specs-container 30"
      style="padding-bottom: 0px"
    >
      <!----><!---->
      <ul _ngcontent-wox-c10="">
        <li _ngcontent-wox-c10="">
          <div _ngcontent-wox-c10="" class="specs p-medium p-medium">
            <div
              _ngcontent-wox-c10=""
              kuitext=""
              style="display: inline-block; font-size: 14px !important"
              data-testid="kui-text"
              class="c-fOVUQc"
            >
              Boost Clock Speed:&nbsp;2.54 GHz
            </div>
          </div>
        </li>
        <li _ngcontent-wox-c10="">
          <div _ngcontent-wox-c10="" class="specs p-medium p-medium">
            <div
              _ngcontent-wox-c10=""
              kuitext=""
              style="display: inline-block; font-size: 14px !important"
              data-testid="kui-text"
              class="c-fOVUQc"
            >
              GPU Memory Size:&nbsp;8 GB
            </div>
          </div>
        </li>
        <!---->
      </ul>
      <!---->
    </div>
    <!----><!---->
    <div
      _ngcontent-wox-c10=""
      class="product_detail_78 nv-priceAndCTAContainer"
    >
      <div
        _ngcontent-wox-c10=""
        data-big-comm-id="3180"
        data-sku-code="NVGFT460T_US"
        class="js-product-item 12"
        style="visibility: visible"
      >
        <div _ngcontent-wox-c10="" class="nv-priceAndCTA">
          <div _ngcontent-wox-c10="" class="nv-priceAndCompare">
            <div _ngcontent-wox-c10="" class="product-details-price-stock">
              <!---->
              <div
                _ngcontent-wox-c10=""
                class="price clearfix h--smallest 81 nv-price"
              >
                <span
                  _ngcontent-wox-c10=""
                  kuitext=""
                  data-testid="kui-text"
                  class="c-fOVUQc"
                  >$399.</span
                ><span
                  _ngcontent-wox-c10=""
                  kuitext=""
                  class="decimal c-fOVUQc"
                  data-testid="kui-text"
                  >00</span
                >
              </div>
              <!---->
            </div>
            <!---->
            <div
              _ngcontent-wox-c10=""
              class="price clearfix h--smallest 81 nv-price price-strike"
            >
              <span
                _ngcontent-wox-c10=""
                kuitext=""
                data-testid="kui-text"
                class="c-fOVUQc"
                >$499.00</span
              ><!----><span
                _ngcontent-wox-c10=""
                kuitext=""
                data-testid="kui-text"
                class="c-fOVUQc"
              >
                Save $100 </span
              ><!---->
            </div>
            <div
              _ngcontent-wox-c10=""
              kuitext=""
              class="nv-compare c-fOVUQc"
              data-testid="kui-text"
            >
              <span _ngcontent-wox-c10="" class="nv-freeShipping"
                >Free Shipping</span
              ><!---->
            </div>
          </div>
          <div _ngcontent-wox-c10="" class="clearfix pdc-86 fe-pids">
            <div
              _ngcontent-wox-c10=""
              style="display: none; visibility: hidden"
              id="104138"
              class="NVGFT460T"
              status="buy_now"
              isfounderedition="true"
            >
              [ { "productId": 104138, "productTitle": "NVIDIA GeForce RTX 4060
              Ti", "logoUrl":
              "https://assets.nvidia.partners/logos/geforce/best_buy.png",
              "isAvailable": true, "salePrice": "399.0", "directPurchaseLink":
              null, "purchaseLink":
              "https://www.bestbuy.com/site/nvidia-geforce-rtx-4060-ti-8gb-gddr6-graphics-card-titanium-and-black/6543946.p?skuId=6543946",
              "hasOffer": false, "offerText": null, "partnerId": "2", "storeId":
              "2", "upc": "NVGFT460T_US", "sku": "NVGFT460T", "stock": 0,
              "retailerName": "https://bestbuy.com", "type": 76, "mrp": "399.0",
              "bestSeller": true }, { "productId": 104138, "productTitle":
              "NVIDIA GeForce RTX 4060 Ti", "logoUrl": null, "isAvailable":
              true, "salePrice": "399.0", "directPurchaseLink":
              "https://marketplace.nvidia.com/en-us/consumer/graphics-cards/nvidia-geforce-rtx-4060-ti/",
              "purchaseLink":
              "https://marketplace.nvidia.com/en-us/consumer/graphics-cards/nvidia-geforce-rtx-4060-ti/",
              "hasOffer": false, "offerText": null, "partnerId": "111",
              "storeId": "51", "upc": "NVGFT460T_US", "sku": "NVGFT460T",
              "stock": 0, "retailerName": "https://www.nvidia.com/en-us/",
              "type": 76, "mrp": "399.0", "bestSeller": true } ]
            </div>
            <div _ngcontent-wox-c10="">
              <div _ngcontent-wox-c10="">
                <div _ngcontent-wox-c10="">
                  <div _ngcontent-wox-c10="">
                    <a
                      _ngcontent-wox-c10=""
                      kuitext=""
                      data-color="#76b900"
                      data-secondary-color="#fff"
                      class="extra_style buy-link-atc cta-link-large 512 js-add-button cta-button c-fOVUQc"
                      data-big-comm-id="3180"
                      data-pid-code="104138"
                      data-producttitle="NVIDIA GeForce RTX 4060 Ti"
                      data-mpn-code="NVGFT460T"
                      data-testid="kui-text"
                      data-listener-added="true"
                      disabled="disabled"
                      >Add to Cart</a
                    ><!---->
                  </div>
                  <!----><!---->
                </div>
                <!---->
              </div>
              <!---->
            </div>
            <!----><!----><!----><!---->
          </div>
        </div>
        <!---->
      </div>
      <!----><!----><!---->
    </div>
    <!---->
  </div>
  <!----><!---->
</div>

Mr-Tech-13 added 3 commits January 12, 2025 12:34

Add 50xx cards, AMD 9xxx CPUs, and copy paste templates for stores

797f3f3

Update amazon.ts

a2690d2

Add templates, add all popular ubiquiti products

a5cfe13

Mr-Tech-13 requested a review from jef as a code owner January 12, 2025 18:16

Mr-Tech-13 added 3 commits January 16, 2025 16:35

Update config.ts

ac6e85a

Update config.ts

a55448e

Update dotenv-example

aa1b97d

jef previously approved these changes Jan 17, 2025

View reviewed changes

jef changed the title ~~Add More 50xx series, All Ubiquiti Wifi, Camera, Switching, and add copy paste templates for adding more links~~ feat: Add More 50xx series, All Ubiquiti Wifi, Camera, Switching, and add copy paste templates for adding more links Jan 17, 2025

jef reviewed Jan 17, 2025

View reviewed changes

dotenv-example Outdated Show resolved Hide resolved

JDIacobbo reviewed Jan 18, 2025

View reviewed changes

src/store/model/newegg.ts Outdated Show resolved Hide resolved

Remove ubiquiti changes, fix typo

e2f2186

Mr-Tech-13 dismissed jef’s stale review via e2f2186 January 18, 2025 22:38

Mr-Tech-13 added 2 commits January 18, 2025 17:47

Update config.ts

54dc239

Fix bug

Merge branch 'main' into main

9b85517

Mr-Tech-13 changed the title ~~feat: Add More 50xx series, All Ubiquiti Wifi, Camera, Switching, and add copy paste templates for adding more links~~ feat: Add More 50xx series, and add copy paste templates for adding more links Jan 18, 2025

jef added 12 commits January 29, 2025 12:38

Update amazon.ts

ea10d71

Update amd.ts

1e02533

Update asus.ts

9854a25

Update bandh.ts

cbfba1d

Update bestbuy.ts

9ff4650

Update newegg.ts

4ac8366

Update pny.ts

21a575d

Update store.ts

6e2ca5d

Update zotac.ts

d93c557

Update config.ts

f48b436

Update dotenv-example

4ce531a

Update config.ts

7dd0ec2

Mr-Tech-13 added 3 commits January 29, 2025 15:54

add bestbuy-ca cards

155181e

Selectors are tested and working

Merge branch 'main' of https://github.com/mr-tech-13/streetmerchant

dbf5ba2

Fix max price error for amd cpus

e8da78c

jef added 3 commits January 29, 2025 13:18

Update bestbuy-ca.ts

d18f750

Update zotac.ts

931ee24

Merge branch 'main' into main

df2e8e7

jef approved these changes Jan 29, 2025

View reviewed changes

jef merged commit ce6d084 into jef:main Jan 29, 2025
3 checks passed

github-actions bot mentioned this pull request Jan 29, 2025

chore(main): release 3.10.0 #3189

Merged

alanbixby mentioned this pull request Jan 29, 2025

feat: Add missing documention + env variables, add country attribute to stores, fix linting errors, deprecate Twitch notification #3198

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add More 50xx series, and add copy paste templates for adding more links #3191

feat: Add More 50xx series, and add copy paste templates for adding more links #3191

Mr-Tech-13 commented Jan 12, 2025

JDIacobbo commented Jan 16, 2025 •

edited

Loading

Mr-Tech-13 commented Jan 16, 2025

Mr-Tech-13 commented Jan 16, 2025

JDIacobbo commented Jan 16, 2025

jef commented Jan 17, 2025

jef commented Jan 17, 2025

Mr-Tech-13 commented Jan 18, 2025

Mr-Tech-13 commented Jan 18, 2025

JDIacobbo commented Jan 19, 2025

P-Adamiec commented Jan 22, 2025

Mr-Tech-13 commented Jan 22, 2025

P-Adamiec commented Jan 22, 2025

P-Adamiec commented Jan 22, 2025

Mr-Tech-13 commented Jan 22, 2025

jef commented Jan 29, 2025

Mr-Tech-13 commented Jan 29, 2025

jef commented Jan 29, 2025

jef left a comment

thetallchap commented Jan 30, 2025

Mr-Tech-13 commented Jan 30, 2025

thetallchap commented Jan 30, 2025

alanbixby commented Jan 30, 2025 •

edited

Loading

feat: Add More 50xx series, and add copy paste templates for adding more links #3191

feat: Add More 50xx series, and add copy paste templates for adding more links #3191

Conversation

Mr-Tech-13 commented Jan 12, 2025

JDIacobbo commented Jan 16, 2025 • edited Loading

Mr-Tech-13 commented Jan 16, 2025

Mr-Tech-13 commented Jan 16, 2025

JDIacobbo commented Jan 16, 2025

jef commented Jan 17, 2025

jef commented Jan 17, 2025

Mr-Tech-13 commented Jan 18, 2025

Mr-Tech-13 commented Jan 18, 2025

JDIacobbo commented Jan 19, 2025

P-Adamiec commented Jan 22, 2025

Mr-Tech-13 commented Jan 22, 2025

P-Adamiec commented Jan 22, 2025

P-Adamiec commented Jan 22, 2025

Mr-Tech-13 commented Jan 22, 2025

jef commented Jan 29, 2025

Mr-Tech-13 commented Jan 29, 2025

jef commented Jan 29, 2025

jef left a comment

Choose a reason for hiding this comment

thetallchap commented Jan 30, 2025

Mr-Tech-13 commented Jan 30, 2025

thetallchap commented Jan 30, 2025

alanbixby commented Jan 30, 2025 • edited Loading

JDIacobbo commented Jan 16, 2025 •

edited

Loading

alanbixby commented Jan 30, 2025 •

edited

Loading