New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regexp no longer required #307

Closed

Skeeve opened this issue Mar 14, 2024 · 1 comment · Fixed by #308

Contributor

Skeeve commented Mar 14, 2024

After switching to ParseFloat, you no longer require the regexp:

go-pretty/text/align.go

Line 26 in 142bdf4

reNumericText = regexp.MustCompile(`^\s*[+\-]?\d*[.]?\d+\s*$`)

jedib0t added a commit that referenced this issue


          remove unused regular expression; fixes #307

220460e

jedib0t mentioned this issue

text: remove unused regular expression #308

Merged

Owner

jedib0t commented Mar 15, 2024

Thanks for the catch. Was benchmarking the performance difference and forgot to remove that after testing.

jedib0t closed this as completed in #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment