Allow no credentials to be passed to #push.

jchauncey · Apr 2, 2014 · 6dbaa1e · 6dbaa1e
1 parent fd83ca2
commit 6dbaa1e
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 2 deletions.
diff --git a/lib/docker/image.rb b/lib/docker/image.rb
@@ -27,8 +27,8 @@ def push(creds = nil, options = {})
 
     raise ArgumentError, "Image does not have a name to push." unless repository
 
-    credentials = creds || Docker.creds
-    headers = Docker::Util.build_auth_header(credentials)
+    creds ||= Docker.creds
+    headers = creds.nil? ? {} : Docker::Util.build_auth_header(creds)
     connection.post(
       "/images/#{repository}/push",
       options,

diff --git a/spec/docker/image_spec.rb b/spec/docker/image_spec.rb
@@ -127,6 +127,17 @@
     it 'pushes the Image', :vcr do
       new_image.push(credentials)
     end
+
+    context 'when there are no credentials' do
+      let(:credentials) { nil }
+
+      before { Docker.creds = nil }
+
+      it 'still pushes', :vcr do
+        expect { base_image.tag('repo' => 'localhost/base', 'tag' => 'latest') }
+          .to_not raise_error
+      end
+    end
   end
 
   describe '#tag' do

diff --git a/spec/vcr/Docker_Image/_push/when_there_are_no_credentials/still_pushes.yml b/spec/vcr/Docker_Image/_push/when_there_are_no_credentials/still_pushes.yml