Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer flushes (fixes #276) #278

Merged
merged 6 commits into from
Apr 29, 2016
Merged

Defer flushes (fixes #276) #278

merged 6 commits into from
Apr 29, 2016

Conversation

jchambers
Copy link
Owner

@jchambers jchambers commented Apr 25, 2016

This change defers calls to flush until either:

  1. a given number of notifications are waiting to be flushed or
  2. the channel has been idle for a given amount of time

This should significantly cut down on the number of calls to flush, which should yield significant performance benefits for users sending lots of notifications. These changes are easiest to read with whitespace-only changes hidden.


TODO:

@jchambers jchambers added this to the v0.6.2 milestone Apr 25, 2016
@jchambers jchambers mentioned this pull request Apr 25, 2016
@jchambers jchambers merged commit 45c2d13 into master Apr 29, 2016
@jchambers jchambers deleted the defer_flushes branch April 29, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant