Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Refacto - Select-view: use native functionnalities of atom-space-pen-views plugin #98

Merged
merged 2 commits into from
Nov 29, 2016

Conversation

lneveu
Copy link
Contributor

@lneveu lneveu commented Nov 27, 2016

PULL REQUEST

According to your comment on this issue ( #89 ), I've refacto the select-view in order to use native functionnalities of the atom-space-pen-views plugin instead of duplicate them.
Now, the list of projects is updated and filtered by the plugin. It also enable fuzzy searching that is natively included. I did some other minor changes:

Fix/Changes:

  • When no projects are found, the "empty message" displays; 'Couldn't find any projects'
  • The list is updated each time a key is pressed (onDidChange instead of onDidStopChanging)

Are you ok with these changes? Please let me know :)
Also, I let you check and tell me if you find any anomalies!

…space-pen-views plugins

Let the plugin manages the update and the filtering (including fuzzy search) of the list of projects
@ghost
Copy link

ghost commented Nov 27, 2016

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description must include verification steps (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

Copy link
Owner

@jccguimaraes jccguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @lneveu :)

@jccguimaraes jccguimaraes merged commit 9804fef into jccguimaraes:master Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants