fix breaking changes with latest zig #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use new runtime pageSize() - popOrNull is now just pop. Added assertions where needed.
Please build only with the specific zig version as noted in zig_version.txt. We intentionally pin to that exact version because that is the version that is supported by zig-gamedev (Mach nominated zig), on which we depend. This PR is unacceptable because it introduces changes that cause building with Please build uscope only with the exact correct version of zig. If you're using zigup, you can do: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really wanted to try out uscope, but couldn't bother building with specific zig version. So I bothered making it work latest zig master.
Fixes issues caused by the following PRs: