Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leading & trailing whitespaces, rework comma insertion between tags #97

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Remove leading & trailing whitespaces, rework comma insertion between tags #97

merged 1 commit into from
Oct 22, 2020

Conversation

romainx
Copy link

@romainx romainx commented Oct 18, 2020

Hello,

Just a small, and pretty useless, improvement to the post footer to

  • remove leading & trailing whitespaces (that can become numerous if shares are not activated) thanks to ability to trim them in Go templates,
  • rework the way tags are separated by commas, credits SO.

Best

@jbub
Copy link
Owner

jbub commented Oct 22, 2020

Thanks for your contribution, nice one!

@jbub jbub merged commit 2ba087e into jbub:master Oct 22, 2020
@romainx
Copy link
Author

romainx commented Oct 22, 2020

Thanks for your feedback, I appreciate 😄. I will continue if I catch other minor improvements.

@romainx romainx deleted the imp_post_footer branch October 22, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainx @jbub