Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes style fix with HTML generated by blackfriday #96

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

romainx
Copy link

@romainx romainx commented Oct 14, 2020

Hello,

Just a small fix to define the class footnotes (instead of footnote) in order to be compliant with output generated by the Blackfriday Markdown processor.

<div class="footnotes">
...
</div>

https://github.com/russross/blackfriday/blob/d3b5b032dc8e8927d31a5071b56e14c89f045135/html.go#L466

Side note: Are you interested by this feature of Hugo that permits to handle transformation of SCSS to CSS during site generation: Hugo Pipes allows the processing of SASS and SCSS files? If so, I could draft a PR 😄

Best.

@jbub
Copy link
Owner

jbub commented Oct 15, 2020

Hello, thanks for your contribution.

We recently closed this one #82, i guess that answers your question :)

@jbub jbub merged commit 19b398e into jbub:master Oct 15, 2020
@romainx romainx deleted the footnotes branch October 15, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants