fix tests path #1346

sbouchet · 2021-05-19T07:25:43Z

Signed-off-by: Stephane Bouchet [email protected]

sbouchet · 2021-05-19T07:26:34Z

@odockal @jkopriva as the repository folders are different than the usual jbosstool structure, let's try to get all the surefire reports directly

odockal · 2021-05-19T07:30:48Z

@sbouchet I see. Let's see how it goes. Just to make it clear, I have copied from old jenkins setup where the number of tests comig from PR was 1. (the dummy one). Not sure if that was alright before ;)

sbouchet · 2021-05-19T08:29:54Z

@sbouchet I see. Let's see how it goes. Just to make it clear, I have copied from old jenkins setup where the number of tests comig from PR was 1. (the dummy one). Not sure if that was alright before ;)

no it wasn't alright even in master !
but old jobs indicates that should be more than 3,000 tests
CC @koentsje

sbouchet · 2021-05-19T15:24:50Z

@koentsje : what do you think ? it enables back the full tests suite with 3835 tests and only 10 fails :)

koentsje · 2021-05-19T15:40:45Z

@sbouchet i am trying to figure out why there are failures because on my machine everything is normal... is there an easy way to get the raw surefire output?

koentsje · 2021-05-19T15:45:58Z

The build also seems to end successfully according to the logs, so I am not sure where these failed tests come from? :-\

2021-05-19T13:42:23.7764886Z [INFO] ------------------------------------------------------------------------
2021-05-19T13:42:23.7771731Z [INFO] Reactor Summary for jbosstools-hibernate 5.4.13-SNAPSHOT:
2021-05-19T13:42:23.7774027Z [INFO]
2021-05-19T13:42:23.7780283Z [INFO] jbosstools-hibernate ............................... SUCCESS [ 0.350 s]
2021-05-19T13:42:23.7783443Z [INFO] Hibernate Tooling Common Stuff ..................... SUCCESS [ 0.039 s]
2021-05-19T13:42:23.7786694Z [INFO] Hibernate Tooling Common Plugins ................... SUCCESS [ 0.032 s]
2021-05-19T13:42:23.7787753Z [INFO] Hibernate Common Library Plugins ................... SUCCESS [ 0.026 s]
2021-05-19T13:42:23.7790624Z [INFO] org.jboss.tools.hibernate.libs.activation.v_1_2_0 .. SUCCESS [ 8.052 s]
2021-05-19T13:42:23.7795914Z [INFO] org.jboss.tools.hibernate.libs.antlr.v_2_7_7 ....... SUCCESS [ 0.387 s]
2021-05-19T13:42:23.7797437Z [INFO] org.jboss.tools.hibernate.libs.bsh.v_2_0_b4 ........ SUCCESS [ 0.335 s]
2021-05-19T13:42:23.7801555Z [INFO] org.jboss.tools.hibernate.libs.dom4j.v_1_6_1 ....... SUCCESS [ 0.307 s]
2021-05-19T13:42:23.7803203Z [INFO] org.jboss.tools.hibernate.libs.freemarker.v_2_3_23 . SUCCESS [ 0.339 s]
2021-05-19T13:42:23.7807015Z [INFO] org.jboss.tools.hibernate.libs.jaxb-api.v_2_3_0 .... SUCCESS [ 0.326 s]
2021-05-19T13:42:23.7810559Z [INFO] org.jboss.tools.hibernate.libs.jaxb-core.v_2_3_0 ... SUCCESS [ 0.338 s]
2021-05-19T13:42:23.7814230Z [INFO] org.jboss.tools.hibernate.libs.jtidy.v_r8-20060801 . SUCCESS [ 0.278 s]
2021-05-19T13:42:23.7820301Z [INFO] Hibernate ORM Tooling .............................. SUCCESS [ 0.026 s]
2021-05-19T13:42:23.7823863Z [INFO] Hibernate ORM Tooling Plugins ...................... SUCCESS [ 0.035 s]
2021-05-19T13:42:23.7825896Z [INFO] Hibernate ORM Core Plugins ......................... SUCCESS [ 0.027 s]
2021-05-19T13:42:23.7833519Z [INFO] Hibernate ORM Runtime Plugins ...................... SUCCESS [ 0.065 s]
2021-05-19T13:42:23.7834759Z [INFO] org.jboss.tools.hibernate.runtime.spi .............. SUCCESS [ 2.025 s]
2021-05-19T13:42:23.7835832Z [INFO] org.hibernate.eclipse .............................. SUCCESS [ 2.050 s]
2021-05-19T13:42:23.7836775Z [INFO] org.hibernate.eclipse.console ...................... SUCCESS [ 3.125 s]
2021-05-19T13:42:23.7840255Z [INFO] org.hibernate.eclipse.help ......................... SUCCESS [ 0.549 s]
2021-05-19T13:42:23.7841253Z [INFO] org.hibernate.eclipse.jdt.ui ....................... SUCCESS [ 1.548 s]
2021-05-19T13:42:23.7842275Z [INFO] org.hibernate.eclipse.mapper ....................... SUCCESS [ 1.210 s]
2021-05-19T13:42:23.7843367Z [INFO] org.jboss.tools.hibernate.jpt.core ................. SUCCESS [ 1.665 s]
2021-05-19T13:42:23.7844502Z [INFO] org.jboss.tools.hibernate.jpt.ui ................... SUCCESS [ 1.501 s]
2021-05-19T13:42:23.7845554Z [INFO] org.jboss.tools.hibernate.ui ....................... SUCCESS [ 1.257 s]
2021-05-19T13:42:23.7846555Z [INFO] org.jboss.tools.hibernate.xml ...................... SUCCESS [ 1.133 s]
2021-05-19T13:42:23.7847616Z [INFO] org.jboss.tools.hibernate.xml.ui ................... SUCCESS [ 0.995 s]
2021-05-19T13:42:23.7848849Z [INFO] org.jboss.tools.hibernate.runtime.common ........... SUCCESS [ 0.821 s]
2021-05-19T13:42:23.7850119Z [INFO] org.jboss.tools.hibernate.runtime.v_3_5 ............ SUCCESS [ 1.027 s]
2021-05-19T13:42:23.7851602Z [INFO] org.jboss.tools.hibernate.runtime.v_3_6 ............ SUCCESS [ 0.939 s]
2021-05-19T13:42:23.7852801Z [INFO] org.jboss.tools.hibernate.runtime.v_4_0 ............ SUCCESS [ 0.931 s]
2021-05-19T13:42:23.7853986Z [INFO] org.jboss.tools.hibernate.runtime.v_4_3 ............ SUCCESS [ 0.868 s]
2021-05-19T13:42:23.7859918Z [INFO] org.jboss.tools.hibernate.runtime.v_5_0 ............ SUCCESS [ 1.023 s]
2021-05-19T13:42:23.7888297Z [INFO] org.jboss.tools.hibernate.runtime.v_5_1 ............ SUCCESS [ 0.861 s]
2021-05-19T13:42:23.7889600Z [INFO] org.jboss.tools.hibernate.runtime.v_5_2 ............ SUCCESS [ 1.077 s]
2021-05-19T13:42:23.7891036Z [INFO] org.jboss.tools.hibernate.runtime.v_5_3 ............ SUCCESS [ 1.026 s]
2021-05-19T13:42:23.7892242Z [INFO] org.jboss.tools.hibernate.runtime.v_5_4 ............ SUCCESS [ 1.314 s]
2021-05-19T13:42:23.7893454Z [INFO] org.jboss.tools.hibernate.runtime.v_5_5 ............ SUCCESS [ 0.970 s]
2021-05-19T13:42:23.7894645Z [INFO] org.jboss.tools.hibernate.runtime.v_6_0 ............ SUCCESS [ 1.475 s]
2021-05-19T13:42:23.7895669Z [INFO] Hibernate ORM UI Plugins ........................... SUCCESS [ 0.033 s]
2021-05-19T13:42:23.7896584Z [INFO] org.jboss.tools.hibernate.orm.ui ................... SUCCESS [ 0.444 s]
2021-05-19T13:42:23.7897510Z [INFO] Hibernate ORM Tooling Test Plugins ................. SUCCESS [ 0.024 s]
2021-05-19T13:42:23.8072736Z [INFO] Hibernate ORM Tooling Core Test Plugins ............ SUCCESS [ 0.021 s]
2021-05-19T13:42:23.8073981Z [INFO] org.hibernate.eclipse.jdt.ui.test .................. SUCCESS [ 35.232 s]
2021-05-19T13:42:23.8075610Z [INFO] org.jboss.tools.hibernate.jpt.core.test ............ SUCCESS [ 0.916 s]
2021-05-19T13:42:23.8077079Z [INFO] org.jboss.tools.hibernate.orm.test ................. SUCCESS [16:23 min]
2021-05-19T13:42:23.8078190Z [INFO] Hibernate ORM Tooling Runtime Test Plugins ......... SUCCESS [ 0.026 s]
2021-05-19T13:42:23.8079451Z [INFO] org.jboss.tools.hibernate.runtime.spi.test ......... SUCCESS [ 13.269 s]
2021-05-19T13:42:23.8080879Z [INFO] org.jboss.tools.hibernate.runtime.v_3_5.test ....... SUCCESS [ 23.815 s]
2021-05-19T13:42:23.8082205Z [INFO] org.jboss.tools.hibernate.runtime.v_3_6.test ....... SUCCESS [ 26.128 s]
2021-05-19T13:42:23.8083523Z [INFO] org.jboss.tools.hibernate.runtime.v_4_0.test ....... SUCCESS [ 22.237 s]
2021-05-19T13:42:23.8084839Z [INFO] org.jboss.tools.hibernate.runtime.v_4_3.test ....... SUCCESS [ 23.246 s]
2021-05-19T13:42:23.8086144Z [INFO] org.jboss.tools.hibernate.runtime.v_5_0.test ....... SUCCESS [ 25.090 s]
2021-05-19T13:42:23.8087457Z [INFO] org.jboss.tools.hibernate.runtime.v_5_1.test ....... SUCCESS [ 23.734 s]
2021-05-19T13:42:23.8088934Z [INFO] org.jboss.tools.hibernate.runtime.v_5_2.test ....... SUCCESS [ 24.994 s]
2021-05-19T13:42:23.8090257Z [INFO] org.jboss.tools.hibernate.runtime.v_5_3.test ....... SUCCESS [ 25.169 s]
2021-05-19T13:42:23.8091722Z [INFO] org.jboss.tools.hibernate.runtime.v_5_4.test ....... SUCCESS [ 24.982 s]
2021-05-19T13:42:23.8093051Z [INFO] org.jboss.tools.hibernate.runtime.v_5_5.test ....... SUCCESS [ 17.619 s]
2021-05-19T13:42:23.8094369Z [INFO] org.jboss.tools.hibernate.runtime.v_6_0.test ....... SUCCESS [ 25.475 s]
2021-05-19T13:42:23.8095488Z [INFO] Hibernate Utilities for ORM Testing Plugins ........ SUCCESS [ 0.017 s]
2021-05-19T13:42:23.8096581Z [INFO] org.jboss.tools.hibernate.reddeer .................. SUCCESS [ 0.853 s]
2021-05-19T13:42:23.8097610Z [INFO] Hibernate Search Tooling ........................... SUCCESS [ 0.039 s]
2021-05-19T13:42:23.8098454Z [INFO] Hibernate Search Tooling Plugins ................... SUCCESS [ 0.045 s]
2021-05-19T13:42:23.8099318Z [INFO] Hibernate Search Core Plugins ...................... SUCCESS [ 0.041 s]
2021-05-19T13:42:23.8100185Z [INFO] Hibernate Search Runtime Plugins ................... SUCCESS [ 0.032 s]
2021-05-19T13:42:23.8101433Z [INFO] org.jboss.tools.hibernate.search.runtime.spi ....... SUCCESS [ 0.441 s]
2021-05-19T13:42:23.8102855Z [INFO] org.jboss.tools.hibernate.search ................... SUCCESS [ 0.761 s]
2021-05-19T13:42:23.8104313Z [INFO] org.jboss.tools.hibernate.search.runtime.common .... SUCCESS [ 0.471 s]
2021-05-19T13:42:23.8105972Z [INFO] org.jboss.tools.hibernate.search.runtime.v_4_0 ..... SUCCESS [ 0.697 s]
2021-05-19T13:42:23.8107528Z [INFO] org.jboss.tools.hibernate.search.runtime.v_5_3 ..... SUCCESS [ 0.775 s]
2021-05-19T13:42:23.8109068Z [INFO] org.jboss.tools.hibernate.search.runtime.v_5_5 ..... SUCCESS [ 0.682 s]
2021-05-19T13:42:23.8110607Z [INFO] org.jboss.tools.hibernate.search.runtime.v_5_5.1 ... SUCCESS [ 0.828 s]
2021-05-19T13:42:23.8112161Z [INFO] org.jboss.tools.hibernate.search.runtime.v_5_7 ..... SUCCESS [ 0.831 s]
2021-05-19T13:42:23.8113389Z [INFO] Hibernate Search Tooling Test Plugins .............. SUCCESS [ 0.008 s]
2021-05-19T13:42:23.8114255Z [INFO] Hibernate Search Core Test Plugins ................. SUCCESS [ 0.008 s]
2021-05-19T13:42:23.8115381Z [INFO] org.jboss.tools.hibernate.search.test .............. SUCCESS [ 0.784 s]
2021-05-19T13:42:23.8116531Z [INFO] hibernatetools.tests ............................... SUCCESS [ 0.008 s]
2021-05-19T13:42:23.8117651Z [INFO] org.jboss.tools.hibernate.dummy.test ............... SUCCESS [ 12.482 s]
2021-05-19T13:42:23.8119487Z [INFO] hibernatetools.test-framework ...................... SUCCESS [ 0.019 s]
2021-05-19T13:42:23.8120554Z [INFO] hibernatetools.itests .............................. SUCCESS [ 0.015 s]
2021-05-19T13:42:23.8121701Z [INFO] org.jboss.tools.hibernate.ui.bot.test .............. SUCCESS [ 1.585 s]
2021-05-19T13:42:23.8122858Z [INFO] hibernatetools.features ............................ SUCCESS [ 0.038 s]
2021-05-19T13:42:23.8124099Z [INFO] org.hibernate.eclipse.feature ...................... SUCCESS [ 0.691 s]
2021-05-19T13:42:23.8125374Z [INFO] org.hibernate.search.eclipse.feature ............... SUCCESS [ 0.477 s]
2021-05-19T13:42:23.8126714Z [INFO] org.hibernate.eclipse.test.feature ................. SUCCESS [ 0.593 s]
2021-05-19T13:42:23.8128196Z [INFO] org.jboss.tools.hibernate.search.test.feature ...... SUCCESS [ 0.262 s]
2021-05-19T13:42:23.8129474Z [INFO] hibernatetools.site ................................ SUCCESS [ 13.766 s]
2021-05-19T13:42:23.8130365Z [INFO] hibernatetools.docs ................................ SUCCESS [ 0.021 s]
2021-05-19T13:42:23.8132833Z [INFO] ------------------------------------------------------------------------
2021-05-19T13:42:23.8133440Z [INFO] BUILD SUCCESS
2021-05-19T13:42:23.8134269Z [INFO] ------------------------------------------------------------------------
2021-05-19T13:42:23.8134881Z [INFO] Total time: 23:19 min
2021-05-19T13:42:23.8135685Z [INFO] Finished at: 2021-05-19T13:42:23Z
2021-05-19T13:42:23.8136542Z [INFO] ------------------------------------------------------------------------

sbouchet · 2021-05-20T08:46:20Z

The GitHub Action replaces the old Jenkins PR jobs. it does not fails on Build ( using this commandline mvn clean verify -U -fae --settings build-ci/maven-settings.xml -DskipITests=true -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true --no-transfer-progress ) so it produces the reports that are then parsed by another action ( Test report )
the raw output is quite simple on it ( https://github.com/jbosstools/jbosstools-hibernate/pull/1346/checks?check_run_id=2620756296) but you can still access the full build log on the first workflow.

koentsje · 2021-05-20T09:33:46Z

@sbouchet Yes I understand and I have looked at the output (and the build logs) that you direct me to but it would be interesting to see the surefire output (and in particular the stack trace) of the particular tests that fail. I have absolutely no clue as to why e.g. the IllegalArgumentExceptions are generated as on my box all seems normal...

sbouchet · 2021-05-21T08:38:40Z

tried locally with the same args and also get a successful result without errors. I then tend to suspect that the image used to run the build (ubuntu) make those tests to fails.
i think it's safe to merge and make another PR to try to log those specific failures.

koentsje · 2021-05-21T10:27:23Z

Ok sure, I can always disable the offending tests for now and try to reproduce on a Ubuntu image (but it will have to wait)

But if I understand correctly there is no way to get/export the complete stack traces of these failing tests? It is quite tedious to have to search the raw output that might even not be in the correct order of execution... :-\

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2021-05-25T08:59:47Z

Ok sure, I can always disable the offending tests for now and try to reproduce on a Ubuntu image (but it will have to wait)

But if I understand correctly there is no way to get/export the complete stack traces of these failing tests? It is quite tedious to have to search the raw output that might even not be in the correct order of execution... :-\

yes, I tried to use the -e to have extra output, but I only get the first stack entry, that is the exact output from the test report. :(

2021-05-20T10:24:36.3272621Z Running org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest
2021-05-20T10:24:36.3427723Z Tests run: 26, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 s <<< FAILURE! - in org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest
2021-05-20T10:24:36.3430045Z testGetNamedType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3432234Z testGetDoubleType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3434671Z testGetTypeFormats(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0.004 s  <<< ERROR!
2021-05-20T10:24:36.3436321Z java.lang.IllegalArgumentException
2021-05-20T10:24:36.3438469Z 	at org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest.testGetTypeFormats(TypeFactoryFacadeTest.java:223)
2021-05-20T10:24:36.3440405Z 
2021-05-20T10:24:36.3441676Z testGetCurrencyType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3444034Z testGetTimezoneType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3446224Z testGetYesNoType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3448376Z testGetLocaleType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3450561Z testGetIntegerType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3452734Z testGetFloatType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3454847Z testGetDateType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3456979Z testGetShortType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3459130Z testGetBasicType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0.001 s
2021-05-20T10:24:36.3461253Z testGetTimeType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3463381Z testGetLongType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3465591Z testGetBigDecimalType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3467812Z testGetByteType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3469993Z testGetTimestampType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3472205Z testGetStringType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3474410Z testGetCharacterType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3476601Z testGetTextType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3478780Z testGetBooleanType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3481082Z testGetClassType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3483260Z testGetCalendarType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3485529Z testGetBigIntegerType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3487846Z testGetCalendarDateType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s
2021-05-20T10:24:36.3490143Z testGetTrueFalseType(org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest)  Time elapsed: 0 s

Signed-off-by: Stephane Bouchet <[email protected]>

jeffmaury · 2021-05-25T09:45:52Z

Noticed usage reporting is not disabled which we were doing on Jenkins, not sure this is the cause of the failed tests

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2021-05-25T12:57:06Z

Noticed usage reporting is not disabled which we were doing on Jenkins, not sure this is the cause of the failed tests

I can see it is correctly disabled, using-Dusage_reporting_enabled=false :
2021-05-20T10:24:22.1809972Z [/opt/hostedtoolcache/jdk/11.0.11/x64/bin/java, -Dosgi.noShutdown=false, -Dosgi.os=linux, -Dosgi.ws=gtk, -Dosgi.arch=x86_64, -javaagent:/home/runner/.m2/repository/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/home/runner/work/jbosstools-hibernate/jbosstools-hibernate/orm/test/runtime/org.jboss.tools.hibernate.runtime.v_3_5.test/target/jacoco.exec,append=true, -Xms512m, -Xmx1024m, -XX:MetaspaceSize=256m, --add-modules=ALL-SYSTEM, -Dusage_reporting_enabled=false, -Dorg.jboss.tools.tests.skipPrivateRequirements=true, -Dorg.eclipse.ui.testsDisableWorkbenchAutoSave=true, -Dosgi.clean=true, -jar, /home/runner/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.100.v20201223-0822/org.eclipse.equinox.launcher-1.6.100.v20201223-0822.jar, -data, /home/runner/work/jbosstools-hibernate/jbosstools-hibernate/orm/test/runtime/org.jboss.tools.hibernate.runtime.v_3_5.test/target/work/data, -install, /home/runner/work/jbosstools-hibernate/jbosstools-hibernate/orm/test/runtime/org.jboss.tools.hibernate.runtime.v_3_5.test/target/work, -configuration, /home/runner/work/jbosstools-hibernate/jbosstools-hibernate/orm/test/runtime/org.jboss.tools.hibernate.runtime.v_3_5.test/target/work/configuration, -application, org.eclipse.tycho.surefire.osgibooter.uitest, -testproperties, /home/runner/work/jbosstools-hibernate/jbosstools-hibernate/orm/test/runtime/org.jboss.tools.hibernate.runtime.v_3_5.test/target/surefire.properties, -timeout, 2400000]

sbouchet · 2021-05-25T13:04:23Z

@koentsje: in my last attempt i added some try/catch to one of the failing test and I got a better stack :

2021-05-25T09:51:04.6318054Z java.lang.IllegalArgumentException
2021-05-25T09:51:04.6319218Z 	at java.base/java.util.Currency.getInstance(Currency.java:393)
2021-05-25T09:51:04.6322560Z 	at org.jboss.tools.hibernate.runtime.common.AbstractTypeFactoryFacade.initializeTypeFormats(AbstractTypeFactoryFacade.java:355)
2021-05-25T09:51:04.6327487Z 	at org.jboss.tools.hibernate.runtime.common.AbstractTypeFactoryFacade.getTypeFormats(AbstractTypeFactoryFacade.java:313)
2021-05-25T09:51:04.6331521Z 	at org.jboss.tools.hibernate.runtime.v_3_5.internal.TypeFactoryFacadeTest.testGetTypeFormats(TypeFactoryFacadeTest.java:225)
2021-05-25T09:51:04.6334195Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-05-25T09:51:04.6336541Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-05-25T09:51:04.6339500Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-05-25T09:51:04.6341705Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2021-05-25T09:51:04.6343282Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2021-05-25T09:51:04.6345577Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2021-05-25T09:51:04.6347988Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2021-05-25T09:51:04.6350449Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2021-05-25T09:51:04.6352511Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2021-05-25T09:51:04.6354098Z 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
2021-05-25T09:51:04.6362635Z 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
2021-05-25T09:51:04.6393256Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
2021-05-25T09:51:04.6395966Z 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
2021-05-25T09:51:04.6397807Z 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
2021-05-25T09:51:04.6399142Z 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
2021-05-25T09:51:04.6400771Z 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
2021-05-25T09:51:04.6402299Z 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
2021-05-25T09:51:04.6403652Z 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
2021-05-25T09:51:04.6404912Z 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
2021-05-25T09:51:04.6406186Z 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
2021-05-25T09:51:04.6407984Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
2021-05-25T09:51:04.6410509Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
2021-05-25T09:51:04.6413240Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
2021-05-25T09:51:04.6415683Z 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
2021-05-25T09:51:04.6417859Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-05-25T09:51:04.6420207Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-05-25T09:51:04.6423147Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-05-25T09:51:04.6425204Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2021-05-25T09:51:04.6427352Z 	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
2021-05-25T09:51:04.6430089Z 	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:161)
2021-05-25T09:51:04.6432640Z 	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:84)
2021-05-25T09:51:04.6435471Z 	at org.eclipse.tycho.surefire.osgibooter.OsgiSurefireBooter.run(OsgiSurefireBooter.java:116)
2021-05-25T09:51:04.6438407Z 	at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication$1.run(AbstractUITestApplication.java:37)
2021-05-25T09:51:04.6440737Z 	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
2021-05-25T09:51:04.6442550Z 	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
2021-05-25T09:51:04.6444505Z 	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5067)
2021-05-25T09:51:04.6446265Z 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4573)
2021-05-25T09:51:04.6448534Z 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1157)
2021-05-25T09:51:04.6451081Z 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
2021-05-25T09:51:04.6453735Z 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1046)
2021-05-25T09:51:04.6456451Z 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
2021-05-25T09:51:04.6458457Z 	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:644)
2021-05-25T09:51:04.6460391Z 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
2021-05-25T09:51:04.6462665Z 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:551)
2021-05-25T09:51:04.6464670Z 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:156)
2021-05-25T09:51:04.6466870Z 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
2021-05-25T09:51:04.6469795Z 	at org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:29)
2021-05-25T09:51:04.6473153Z 	at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:122)
2021-05-25T09:51:04.6476334Z 	at org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:35)
2021-05-25T09:51:04.6478981Z 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
2021-05-25T09:51:04.6482229Z 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
2021-05-25T09:51:04.6485878Z 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
2021-05-25T09:51:04.6488667Z 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
2021-05-25T09:51:04.6490876Z 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
2021-05-25T09:51:04.6493143Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-05-25T09:51:04.6495749Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-05-25T09:51:04.6498698Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-05-25T09:51:04.6500902Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2021-05-25T09:51:04.6502473Z 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
2021-05-25T09:51:04.6504212Z 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
2021-05-25T09:51:04.6505653Z 	at org.eclipse.equinox.launcher.Main.run(Main.java:1461)
2021-05-25T09:51:04.6507190Z 	at org.eclipse.equinox.launcher.Main.main(Main.java:1434)

so it looks like all the IllegalArgumentExceptions are coming from here?
addTypeFormat(getCurrencyType(), Currency.getInstance(Locale.getDefault()));

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2021-05-25T13:31:54Z

converted to draft as i'm trying to identify the cause. it seems related to the locale used by the image that is not supported. locally,n the Currency/Locale is ok. (Currency=EUR, Locale=fr_FR)

sbouchet · 2021-05-25T14:08:26Z

ok, i'm going somewhere..
the output from the build says that locale is 'en' and the Currency is 'null' so the illegalArgumentException. After digging a bit, it seems the locale used by ubuntu image is C.UTF-8 and the fix is to set a correct locale in the environment ( see actions/runner-images#3120)

Signed-off-by: Stephane Bouchet <[email protected]>

koentsje · 2021-05-25T18:14:19Z

i have the week off, so I am only looking from far at this... in any case thanks for digging into it ;-)

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet · 2021-06-02T07:37:00Z

@odockal @jkopriva @koentsje finally got the locale config working and no more test failures. 😄

koentsje · 2021-06-02T11:08:37Z

oh boy, w00t w00t !!!

thanks for all your efforts in any case, very much appreciated :-)

odockal · 2021-06-02T11:14:58Z

@sbouchet From my point of view the changes look good. Though I am curious what is default system locale setup. Otherwise nice job.

sbouchet · 2021-06-02T15:05:21Z

@sbouchet From my point of view the changes look good. Though I am curious what is default system locale setup. Otherwise nice job.

it was set to something like "C.UTF-8"

sbouchet requested a review from jkopriva May 19, 2021 07:25

sbouchet requested a review from koentsje May 19, 2021 15:24

sbouchet force-pushed the fgix_gh_test_path branch from f1f19bb to 7290566 Compare May 20, 2021 10:05

sbouchet added 3 commits May 25, 2021 09:32

fix tests path

3fae41d

Signed-off-by: Stephane Bouchet <[email protected]>

fix typo and remove quiet flag

1ee68bf

Signed-off-by: Stephane Bouchet <[email protected]>

added extra B and e flags to build

de53363

Signed-off-by: Stephane Bouchet <[email protected]>

Added log to attempt test failure fix

c821ffb

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet force-pushed the fgix_gh_test_path branch from 7290566 to c821ffb Compare May 25, 2021 09:32

use correct tycho source feature config

7cf960a

Signed-off-by: Stephane Bouchet <[email protected]>

attempt to fix test.

49d6cd8

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet marked this pull request as draft May 25, 2021 13:30

sbouchet force-pushed the fgix_gh_test_path branch 2 times, most recently from 62502a2 to b43b9b9 Compare May 25, 2021 14:31

added configure locale step

63c1f02

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet force-pushed the fgix_gh_test_path branch from b43b9b9 to 63c1f02 Compare May 25, 2021 16:12

sbouchet added 3 commits June 1, 2021 15:20

attempt to fix locale

043dcba

Signed-off-by: Stephane Bouchet <[email protected]>

attempt to fix locale

d5d039f

Signed-off-by: Stephane Bouchet <[email protected]>

revert extra log

9d21977

Signed-off-by: Stephane Bouchet <[email protected]>

sbouchet marked this pull request as ready for review June 2, 2021 08:15

koentsje approved these changes Jun 2, 2021

View reviewed changes

sbouchet merged commit ed9115f into jbosstools:master Jun 2, 2021

sbouchet deleted the fgix_gh_test_path branch June 2, 2021 15:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix tests path #1346

fix tests path #1346

sbouchet commented May 19, 2021

sbouchet commented May 19, 2021

odockal commented May 19, 2021

sbouchet commented May 19, 2021

sbouchet commented May 19, 2021

koentsje commented May 19, 2021

koentsje commented May 19, 2021

sbouchet commented May 20, 2021

koentsje commented May 20, 2021

sbouchet commented May 21, 2021

koentsje commented May 21, 2021

sbouchet commented May 25, 2021

jeffmaury commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021 •

edited

Loading

koentsje commented May 25, 2021

sbouchet commented Jun 2, 2021

koentsje commented Jun 2, 2021

odockal commented Jun 2, 2021

sbouchet commented Jun 2, 2021

fix tests path #1346

fix tests path #1346

Conversation

sbouchet commented May 19, 2021

sbouchet commented May 19, 2021

odockal commented May 19, 2021

sbouchet commented May 19, 2021

sbouchet commented May 19, 2021

koentsje commented May 19, 2021

koentsje commented May 19, 2021

sbouchet commented May 20, 2021

koentsje commented May 20, 2021

sbouchet commented May 21, 2021

koentsje commented May 21, 2021

sbouchet commented May 25, 2021

jeffmaury commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021

sbouchet commented May 25, 2021 • edited Loading

koentsje commented May 25, 2021

sbouchet commented Jun 2, 2021

koentsje commented Jun 2, 2021

odockal commented Jun 2, 2021

sbouchet commented Jun 2, 2021

sbouchet commented May 25, 2021 •

edited

Loading