Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: javadoc plugin uses additionalOptions #51

Merged
merged 2 commits into from
Sep 6, 2018
Merged

fix: javadoc plugin uses additionalOptions #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c23bac
fix: javadoc plugin uses additionalOptions
bartoszmajsak Sep 5, 2018
b04d457
chore: adds comment about keeping additionalparam for backward compat…
bartoszmajsak Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@
</manifestEntries>
</archive>
<additionalparam>${javadoc.additional.params}</additionalparam>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if additionalparam was replaced with additionalOptions the line should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stated the reason why I decided not to in the PR description:

I left additionalparam for backward compatibility in case someone uses old plugin by overwriting a version.

If you feel like it's not a reason good enough I can remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've missed that. May be it would be good to add the comment to the respective line why it is there (additionalparam line) and which versions of plugin it is meant for (both lines) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added in b04d457

<additionalOptions>${javadoc.additional.params}</additionalOptions>
</configuration>
</plugin>
<plugin>
Expand Down