feat: prepare 0.24.0 release #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linux-china
commented
Jan 18, 2023
linux-china
commented
- Added: enable download sources
- Added: attach sources for jbang lib when syncing dependencies
- Added: NATIVE_OPTIONS support
- Fixed: support for quoted arguments in the build configuration
maxandersen
reviewed
Jan 19, 2023
| @@ -375,7 +374,10 @@ class SyncDependenciesAction : AnAction() { | |||
| } | |||
| // add jbang dependencies | |||
| if (newDependencies.isNotEmpty()) { | |||
| ModuleRootModificationUtil.addModuleLibrary(module, libName, newDependencies.map { "jar://${it}!/" }.toList(), listOf()) | |||
| ModuleRootModificationUtil.addModuleLibrary(module, libName, | |||
There was a problem hiding this comment.
What happens if the sources jar is not there?
There was a problem hiding this comment.
No worry, and IDEA will ignore it if source file does not exist.
| @@ -26,6 +26,8 @@ fun getJBangCmdAbsolutionPath(): String { | |||
| return if (SystemInfo.isWindows) { | |||
| if (File(System.getenv("JBANG_HOME") ?: "", "bin/jbang.cmd").exists()) { | |||
| File(System.getenv("JBANG_HOME") ?: "", "bin/jbang.cmd").absolutePath | |||
| } else if (File(userHome, ".sdkman/candidates/jbang/current/bin/jbang.cmd").exists()) { | |||
There was a problem hiding this comment.
Not following why sdkman should get special treatment - everywhere else we check JBANG_HOME, PATH and ~/.jbang/bin
With this change users can't reliably know which jbang gets used.
There was a problem hiding this comment.
Got. I will remove it in version 0.25.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.