-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run codecov in appveyor ci #745
Conversation
This will likely cause problems with codecov timing out though - if there are non already (given the huge number of builds for linux already). So in general it would be better to only run selective envs with coverage, by using a coverage factor in tox (see pytest's tox.ini). |
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 86.07% 87.27% +1.19%
==========================================
Files 33 33
Lines 2126 2082 -44
Branches 303 303
==========================================
- Hits 1830 1817 -13
+ Misses 231 201 -30
+ Partials 65 64 -1
Continue to review full report at Codecov.
|
@blueyed could you please tell me what kind of problems do you mean? |
@atugushev |
Here https://codecov.io/gh/jazzband/pip-tools/pull/745?src=pr&el=h1 is not timing out, although there are a lot of builds. |
So I suggest adding flags ("windows" / "linux" (or rather |
I see. Running selective envs with coverage sounds reasonable to me now. I'll try to test it and propose a PR soon.
Builds section looks pretty good now, see the latest codecov report. Thanks for the suggestion, Daniel! |
Co-Authored-By: Daniel Hahler <[email protected]>
1bc0bb1
to
fc69f3a
Compare
For reference: extra coverage due to this: https://codecov.io/gh/jazzband/pip-tools/compare/c45862bd3e99df71fc020f828395fc7f6766be7c...fc69f3a2eab8d54c1a9850dcb2fdd9ec3d6930c5/changes But it could be achieved with a single (or few) jobs only probably also. |
Increases the test coverage.