-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include py.typed
in wheel file
#1648
Include py.typed
in wheel file
#1648
Conversation
0ac87d5
to
c87d767
Compare
21acaec
to
9df2918
Compare
FYI I've canceled the CI jobs for this PR to get some air for the release build. Feel free to re-run after |
setup.cfg
Outdated
|
||
[options] | ||
python_requires = >=3.7 | ||
setup_requires = setuptools_scm | ||
packages = find: | ||
include_package_data = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include_package_data = true | |
package_data = piptools = py.typed |
Mayby explicitly define certain package data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atugushev Thanks! This line was not working but I found how to do it properly here. That's much better than include_package_data
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
py.typed
in wheel file
Resolves #1610
I have tweaked the
setup.cfg
file in order to add thepy.typed
file in the wheel (it was already packaged in the zip file). I also added the classifierTyping :: Typed
.I am not sure ifinclude_package_data = true
can have any unwanted side effect. So far it looks like it only added the missingpy.typed
file to the wheel.Now using
options.package_data
.I tested the changes in the wheel using the following code:
Before:
After:
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.