-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release drafter github action #1416
Conversation
This change should help preparing list of release notes for future releases. When a maintainer will want to make a release he would be able to tune the draft release notes and copy them to the changelog. The biggest advantage of this change is that the creation of the draft is automated and it already uses the desired format, with title link to PR and mention of author, reducing the maintenance chore when preparing for a new release.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that looks pretty useful! A few notes below:
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, this needs to lose the use of the verify-pr-label-action action to be mergable. Release-drafter is already used in other Jazzband projects and is acceptable.
@atugushev @jezdez Does it look ok now? Did I miss anything or is ready for approval. I can wait for two approvals for this one if you think that is needed. |
@atugushev Can you please review this? I would like to enable it so we can benefit from it for the new release. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinging! A few notes below:
Co-authored-by: Albert Tugushev <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@atugushev Please give it another go, I hope I addressed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change to the action config needed, but otherwise this looks good to me.
@jezdez Added that change. Please do not forget to approve it. As long you appear with "requested changes" we will not be able to merge the change, regardless other approvals. |
This change should help preparing list of release notes for future
releases. When a maintainer will want to make a release he would
be able to tune the draft release notes and copy them to the
changelog.
The biggest advantage of this change is that the creation of the
draft is automated and it already uses the desired format, with
title link to PR and mention of author, reducing the maintenance
chore when preparing for a new release.
Changelog-friendly one-liner:
Contributor checklist