Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

via not shown for packages installed from VCS #293

Closed
cancan101 opened this issue Jan 14, 2016 · 3 comments · Fixed by #1058
Closed

via not shown for packages installed from VCS #293

cancan101 opened this issue Jan 14, 2016 · 3 comments · Fixed by #1058
Labels
annotations Related to packages annotations enhancement Improvements to functionality PR wanted Feature is discussed or bug is confirmed, PR needed

Comments

@cancan101
Copy link

my requirements.in file has:

-e git+https://github.com/scikit-image/scikit-image.git@33646e0#egg=scikit-image==0.12.git

but the .txt just shows:

dask[array]==0.7.6

without showing the via. This even though I gave the package a name with the egg=.
@jonafato jonafato mentioned this issue Jul 24, 2017
Closed
@vphilippon
Copy link
Member

vphilippon commented Nov 24, 2017 •
edited
Loading

FTR, I stumbled on the cause of this in the code: The editable dependencies are never added to the dependency cache (which is ok, editable packages requirements are likely to change for a same version), and the OutputWriter uses the reversed dependency cache to generate the "via" comments.

@suutari-ai
Copy link
Contributor

suutari-ai commented Nov 27, 2017 •
edited
Loading

This probably isn't directly usable in pip-tools, but if it's any help, here's how I implemented this feature to Prequ: suutari@634ef5c

@jmbowman jmbowman mentioned this issue Mar 29, 2018
Merged
@jmbowman jmbowman mentioned this issue Apr 11, 2018
Merged
@richafrank
Copy link
Contributor

@vphilippon I'd love to see this enhancement. If I submit a PR using the design from above, would that be welcome, i.e. filtering out editable dependencies at persistence time? Another idea is to maintain a separate in-memory-only cache for editables.

@atugushev atugushev added the PR wanted Feature is discussed or bug is confirmed, PR needed label Aug 14, 2019
This was referenced Sep 15, 2019
Closed
Closed
@atugushev atugushev added the enhancement Improvements to functionality label Sep 19, 2019
This was referenced Feb 7, 2020
Closed
Merged
AndydeCleyre added a commit to AndydeCleyre/pip-tools that referenced this issue Feb 19, 2020
@AndydeCleyre @atugushev
Rework reverse dep tracking for annotations, now appearing for primar…
ca69a92 
…y and VCS reqs; fixes jazzband#881 and jazzband#293

Change Notes
------------

- Annotations now include reqsin/setup.py/stdin info when relevant
- Always send reverse_dependencies to writer._format_requirement as a dict, even if empty
- Invert checks for primary requirements not getting annotations, as they now do
- Bypass annotation noise in tests which don't target annotations anyway, by passing --no-annotate
- ireqs returned by get_best_match now have the parameter ireq's _source_ireqs, if any
- reverse_dependencies are no longer passed around independently outside the
  resolver/cache, but rather determined from an ireq's comes_from and _source_ireqs
- primary_packages are no longer passed around independently, but rather determined by
  an ireq's constraint
- In tests, reverse dependencies for fake ireqs are now specified by setting the ireq's
  comes_from
- These changes do _not_ improve handling of relative paths to reqsin files in annotations (see jazzband#1067)

Co-authored-by: Albert Tugushev <[email protected]>
@atugushev atugushev added the annotations Related to packages annotations label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
annotations Related to packages annotations enhancement Improvements to functionality PR wanted Feature is discussed or bug is confirmed, PR needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Annotate primary requirements and VCS dependencies AndydeCleyre/pip-tools
5 participants
@cancan101 @richafrank @vphilippon @suutari-ai @atugushev