Allow None for JTI_CLAIM and TOKEN_TYPE_CLAIM #489
Conversation
This is the only way I could get it working with an Auth0 JWT, which has neither 'jti' nor 'token_type'.
|
Related to #279 |
|
Related to #227 |
|
Related to #106 |
|
Related to #169 |
|
Closing due to inactivity and I don't think it's supposed to be None. |
|
@Andrew-Chen-Wang errr, excuse me? You don't look at this PR for 3 months, and then you just close it?! I've been running Do you have any alternative solution in mind, for supporting an Auth0 JWT? If not, then could you please re-open this PR, and consider merging it? |
|
@davesque any chance you could chime in here? |
|
Yes, I'm an inconsistent maintainer with flaws -- obviously not reading the spec for one -- who probably failed his exams 5 hours ago? I don't use Auth0, so please be patient as I closed this for inactivity. I didn't say I didn't care. |
| if api_settings.TOKEN_TYPE_CLAIM is not None: | ||
| self.verify_token_type() |
There was a problem hiding this comment.
At first this seemed strange, but I remembered it's Auth0. If possible, please leave a comment mentioning how this should only apply to outside services. Customization of tokens should still stride to use the TOKEN_TYPE_CLAIM setting. A test case would be great!
|
@Andrew-Chen-Wang thanks for re-opening an reviewing. I'll add a comment and a test case as you've suggested. Sorry if I sounded rude. I know, this is open source, you're a volunteer, you have limited time, you have to cull issues that might be abandoned, for your sanity. I don't expect you to be familiar with Auth0, nor with any other third-party services that people might use. I appreciate you maintaining this library. Keep it up. |
|
Np and no worries. Sometimes my own prose are fairly rude, so understandable. Thanks for understanding. Looking for one more check by @2ykwang |
|
lgtm then thanks! |
|
@Andrew-Chen-Wang, do you know when this might be merged? Thanks in advance Edit : I have opened a pr here #567 |
|
thanks @denniskeends !!! |
This is the only way I could get it working with an Auth0 JWT, which has neither 'jti' nor 'token_type'.