Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 compatibility #446

Merged
merged 1 commit into from
Jun 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Django 4.0 compatibility
  • Loading branch information
triopter committed Jun 19, 2022
commit 04de77dd441283108950e60b21d645fbaa18c080
7 changes: 6 additions & 1 deletion test_app/models.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
from django.contrib.auth.base_user import AbstractBaseUser
from django.db import models
from django.db.models import CASCADE
from django.utils.translation import ugettext_lazy as _

# ugettext variants removed in Django 4.0. Only gettext now available
try:
from django.utils.translation import ugettext_lazy as _
except ImportError:
from django.utils.translation import gettext_lazy as _

from waffle.models import AbstractUserFlag, CACHE_EMPTY
from waffle.utils import get_setting, keyfmt, get_cache
Expand Down
6 changes: 5 additions & 1 deletion test_app/urls.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from django.conf.urls import url, include
try:
from django.conf.urls import url
except ImportError:
from django.urls import re_path as url
from django.urls import include
from django.contrib import admin
from django.http import HttpResponseNotFound, HttpResponseServerError

Expand Down
6 changes: 5 additions & 1 deletion waffle/tests/test_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ def get(**kw):
return request


def get_response(request):
return 'hello'


def process_request(request, view):
response = view.as_view()(request)
return WaffleMiddleware().process_response(request, response)
return WaffleMiddleware(get_response).process_response(request, response)


class WaffleFlagMixinTest(TestCase):
Expand Down
7 changes: 5 additions & 2 deletions waffle/tests/test_templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@ def get():
return request


def get_response(request):
return 'hello'


def process_request(request, view):
response = view(request)
return WaffleMiddleware().process_response(request, response)
return WaffleMiddleware(get_response).process_response(request, response)


class WaffleTemplateTests(TestCase):

def test_django_tags(self):
request = get()
response = process_request(request, views.flag_in_django)
Expand Down
6 changes: 5 additions & 1 deletion waffle/tests/test_waffle.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,13 @@ def get(**kw):
return request


def get_response(request):
return 'hello'


def process_request(request, view):
response = view(request)
return WaffleMiddleware().process_response(request, response)
return WaffleMiddleware(get_response).process_response(request, response)


class WaffleTests(TestCase):
Expand Down