Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A single settings dict #182

Open
jsocol opened this issue Oct 21, 2015 · 2 comments
Open

A single settings dict #182

jsocol opened this issue Oct 21, 2015 · 2 comments
Labels
pinned semver:minor
Milestone
1.0 - 0.1

Comments

@jsocol
Copy link
Collaborator

jsocol commented Oct 21, 2015

The trend in django core has been to move from lots of NAMESPACE_* settings to NAMESPACE = {'FOO': 1}. I think in the interest of reducing settings namespace bloat, and simplifying some code in a few places (well, replacing getattr() with .get(), mostly), this is a good trend and we should move the WAFFLE_* settings into a WAFFLE dict.
@jsocol jsocol mentioned this issue Oct 21, 2015
Open
@willkg
Copy link
Collaborator

willkg commented Oct 21, 2015

I'm +1 on this.

@jsocol jsocol added this to the 0.12 milestone Oct 21, 2015
@jsocol
Copy link
Collaborator Author

jsocol commented Oct 21, 2015

Since it's another breaking change, I'm putting it in 0.12 for now.

cleder added a commit to PrimarySite/django-waffle that referenced this issue Jun 1, 2016
@cleder
move settings into a single dict fixes jazzband#182
432a42d
@jsocol jsocol mentioned this issue Jan 16, 2017
Closed
@clintonb clintonb modified the milestones: 0.13, 0.12 Jun 28, 2017
@jsocol jsocol added the pinned label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned semver:minor
Projects
None yet
Milestone
1.0 - 0.1
Development

No branches or pull requests
3 participants
@jsocol @willkg @clintonb