Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize setup.cfg and pyproject.toml #77

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Conversation

shimizukawa
Copy link
Member

Feature or Bugfix

  • Feature

Purpose

  • Move setup.py parameters into setup.cfg

Detail

  • Since setuptools-30.3.0 (8 Dec 2016), almost all parameters can now be written in setup.cfg.

Relates

@shimizukawa shimizukawa self-assigned this Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #77 (66dc1fe) into master (16dcd4a) will increase coverage by 1.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   45.49%   47.01%   +1.52%     
==========================================
  Files           3        3              
  Lines         244      251       +7     
  Branches       62       62              
==========================================
+ Hits          111      118       +7     
  Misses        123      123              
  Partials       10       10              
Impacted Files Coverage Δ
django_redshift_backend/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dcd4a...66dc1fe. Read the comment docs.

@shimizukawa
Copy link
Member Author

Uploaded information on test pypi looks fine.
https://test.pypi.org/project/django-redshift-backend/2.0.2.dev8/

[tool.setuptools_scm]
# this empty section means: use_scm_version=True
version_scheme = "guess-next-dev"
local_scheme = "no-local-version"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPI does not allow local-version part +ga4d8bf9

> twine upload -r testpypi dist\django-redshift-backend-2.0.2.dev8+ga4d8bf9.tar.gz
Uploading distributions to https://test.pypi.org/legacy/
Uploading django-redshift-backend-2.0.2.dev8+ga4d8bf9.tar.gz
...
HTTPError: 400 Bad Request from https://test.pypi.org/legacy/
'2.0.2.dev8+ga4d8bf9' is an invalid value for Version. Error: Can't use PEP 440 local versions. See https://packaging.python.org/specifications/core-metadata for more information.

@shimizukawa shimizukawa changed the title modernize setup.cfg modernize setup.cfg and pyproject.toml Mar 8, 2021
@shimizukawa shimizukawa merged commit 7b1b735 into master Mar 8, 2021
@shimizukawa shimizukawa deleted the modernize-setupcfg branch March 8, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant