Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify FILTER WHERE syntax not supported #62

Closed

Conversation

michaelwheeler
Copy link
Contributor

Subject: Redshift doesn't support FILTER WHERE syntax

Feature or Bugfix

  • Bugfix

Purpose

  • This PR just marks supports_aggregate_filter_clause as an unsupported database feature so that the ORM will fallback to CASE statements in conditional aggregation.

Detail

@michaelwheeler
Copy link
Contributor Author

Not in a huge hurry to fix the failing tests since Django 1.11 extended support will be ending in April, and I see in #50 that support is planned to be removed from this library as well. Please let me know if that is a problem.

Kostja P and others added 12 commits November 2, 2020 15:28
removed curly braces in port description
Let users choose between psycopg2 binary or source
* Move CI to Github Actions

* Move CI to Github Actions - take 2

* Fix flake8 error

* Add deployment step

* Tidy up

* Update trigger for CI workflow

* Simplify test matrix with tox-gh-actions

* Exclude unsuitable matrix combinations

* Add Python 3.5 back

* Update deployment steps to use Jazzband index

* Split CI workflow into test, lint and deploy

* Rename deploy workflow  to match Jazzband precendence.

* Remove unused Docker files.

* Fix URL.

* Update test workflow.

- Tracks test coverage.
- Drops support for  Python 2.7 and 3.5, new minimum Python is  3.6.
- Drops support for Django 1.11, 2.0 and 2.1.
- Adds support for Django  3.0 and 3.1.
- Fix flake8 run.

* Fix a few Django warnings.

* Update lint workflow.

* Fix badges and URLs.

* Update changelog.

Co-authored-by: Bruno Alla <[email protected]>
Once it has been properly uploaded to PyPI, raise the version to 2.0.0.
@michaelwheeler
Copy link
Contributor Author

Is it possible to rerun tests on this PR? I think it should be passing now that support for older Python and Django versions has been removed.

@shimizukawa
Copy link
Member

@michaelwheeler can you rebase this PR on to origin/master?
We have moved from travis to github actions at #72 Jan 4, 2021.

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@6f20688). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage          ?   45.04%           
=========================================
  Files             ?        3           
  Lines             ?      242           
  Branches          ?       62           
=========================================
  Hits              ?      109           
  Misses            ?      123           
  Partials          ?       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f20688...c88b1b9. Read the comment docs.

@michaelwheeler
Copy link
Contributor Author

Replaced by #74 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants