-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify FILTER WHERE syntax not supported #62
Specify FILTER WHERE syntax not supported #62
Conversation
Not in a huge hurry to fix the failing tests since Django 1.11 extended support will be ending in April, and I see in #50 that support is planned to be removed from this library as well. Please let me know if that is a problem. |
removed curly braces in port description
Let users choose between psycopg2 binary or source
Update refs.rst
* Move CI to Github Actions * Move CI to Github Actions - take 2 * Fix flake8 error * Add deployment step * Tidy up * Update trigger for CI workflow * Simplify test matrix with tox-gh-actions * Exclude unsuitable matrix combinations * Add Python 3.5 back * Update deployment steps to use Jazzband index * Split CI workflow into test, lint and deploy * Rename deploy workflow to match Jazzband precendence. * Remove unused Docker files. * Fix URL. * Update test workflow. - Tracks test coverage. - Drops support for Python 2.7 and 3.5, new minimum Python is 3.6. - Drops support for Django 1.11, 2.0 and 2.1. - Adds support for Django 3.0 and 3.1. - Fix flake8 run. * Fix a few Django warnings. * Update lint workflow. * Fix badges and URLs. * Update changelog. Co-authored-by: Bruno Alla <[email protected]>
Once it has been properly uploaded to PyPI, raise the version to 2.0.0.
Is it possible to rerun tests on this PR? I think it should be passing now that support for older Python and Django versions has been removed. |
@michaelwheeler can you rebase this PR on to origin/master? |
…r/django-redshift-backend into no-aggregate-filter-clause
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage ? 45.04%
=========================================
Files ? 3
Lines ? 242
Branches ? 62
=========================================
Hits ? 109
Misses ? 123
Partials ? 10 Continue to review full report at Codecov.
|
Replaced by #74 . |
Subject: Redshift doesn't support FILTER WHERE syntax
Feature or Bugfix
Purpose
supports_aggregate_filter_clause
as an unsupported database feature so that the ORM will fallback to CASE statements in conditional aggregation.Detail