Support Django 2.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surgo
commented
Jun 21, 2018
| @@ -23,5 +23,5 @@ class TestParentModel(models.Model): | |||
|
|
|||
|
|
|||
| class TestChildModel(models.Model): | |||
| parent = models.ForeignKey(TestParentModel) | |||
| parent = models.ForeignKey(TestParentModel, on_delete=models.CASCADE) | |||
There was a problem hiding this comment.
on_delete is always required.
https://docs.djangoproject.com/en/2.0/releases/1.9/#foreignkey-and-onetoonefield-on-delete-argument
Surgo
commented
Jun 21, 2018
django_redshift_backend/base.py
Outdated
| @@ -159,8 +159,10 @@ def create_model(self, model): | |||
| definition += " %s" % col_type_suffix | |||
| params.extend(extra_params) | |||
| # FK | |||
| if field.rel and field.db_constraint: | |||
| to_table = field.rel.to._meta.db_table | |||
| if field.remote_field and field.db_constraint: | |||
There was a problem hiding this comment.
Field.rel is deprecated in 1.9 and removed in 2.0.
https://docs.djangoproject.com/en/2.0/releases/1.9/#field-rel-changes
Surgo
commented
Jun 21, 2018
| 'Framework :: Django :: 1.11', | ||
| 'Framework :: Django :: 2.0', |
shimizukawa
requested changes
Jun 21, 2018
django_redshift_backend/base.py
Outdated
| if field.remote_field and field.db_constraint: | ||
| to_table = field.remote_field.to._meta.db_table | ||
| to_column = field.remote_field.to._meta.get_field( | ||
| field.remote_field.field_name).column | ||
| to_column = field.rel.to._meta.get_field(field.rel.field_name).column |
There was a problem hiding this comment.
I think this line must be removed because new code is provided at one line before.
| 'Framework :: Django :: 1.11', | ||
| 'Framework :: Django :: 2.0', |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Support Django 2.0
Feature or Bugfix
Relates