Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to promise #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

picheli20
Copy link

Solve #6

@jaz303
Copy link
Owner

jaz303 commented Jul 26, 2018

I'm not willing to break support for the callback style as this project has a large number of dependents.

It's trivially possible to automatically convert the callback async style into a promise-based equivalent (e.g. via es6-promisify) so I would question the need for this.

I wouldn't be against providing this wrapper in the main package, e.g. require('git-clone/promise'). How does this sound?

@picheli20
Copy link
Author

yeah, sounds good as well. I'll update my PR

@picheli20 picheli20 force-pushed the support-to-promise branch 4 times, most recently from 019b1d8 to 00db80c Compare July 26, 2018 15:51
@picheli20 picheli20 force-pushed the support-to-promise branch from 00db80c to fdb8e54 Compare July 26, 2018 15:52
@Sceat
Copy link

Sceat commented Jan 8, 2019

@jaz303 could this be merged and published on npm ? thanks

@MichaelDimmitt
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants