Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Slice rather than Vec to access expr planners #3

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

alamb
Copy link

@alamb alamb commented Jul 16, 2024

Proposed change to apache#11485

This shows how we could use a slice rather than having to copy vectors on each access

@alamb alamb force-pushed the alamb/use_slice branch from 2d09977 to 38b3ff4 Compare July 16, 2024 21:19
@github-actions github-actions bot removed documentation Improvements or additions to documentation physical-expr substrait sqllogictest labels Jul 16, 2024
@alamb alamb changed the title Alamb/use slice Use Slice rather than Vec to access expr planners Jul 16, 2024
@jayzhan211 jayzhan211 merged commit ef39772 into jayzhan211:planner Jul 17, 2024
2 of 3 checks passed
@alamb alamb deleted the alamb/use_slice branch July 17, 2024 10:29
jayzhan211 pushed a commit that referenced this pull request Feb 11, 2025
…4544)

* add mut annotation

* fix rust examples

* fix rust examples

* update

* fix first doctest

* fix first doctest

* fix more doctest

* fix more doctest

* fix more doctest

* adopt rustdoc syntax

* adopt rustdoc syntax

* adopt rustdoc syntax

* fix more doctest

* add missing imports

* final udtf

* reenable

* remove dep

* run prettier

* api-health

* update doc

* update doc

* temp fix

* fix doc

* fix async schema provider

* fix async schema provider

* fix doc

* fix doc

* reorder

* refactor

* s

* finish

* minor update

* add missing docs

* add deps (#3)

* fix doctest

* update doc

* fix doctest

* fix doctest

* tweak showkeys

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* update to use user_doc

* add rustdoc preprocessing

* fix dir

* revert to original doc

* add allocator

* mark type

* update

* fix doctest

* add doctest

* add doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* prettier format

* revert change to datafusion-testing

* add apache header

* install cmake in setup-builder for ci workflow dependency

* taplo + fix snmalloc

* Update function docs

* preprocess user-guide

* Render examples as sql

* fix intro

* fix docs via script

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants