Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 #15

Closed
jayvdb opened this issue Feb 26, 2020 · 1 comment
Closed

Python 3.8 #15

jayvdb opened this issue Feb 26, 2020 · 1 comment
Assignees
@jayvdb

Comments

@jayvdb
Copy link
Owner

jayvdb commented Feb 26, 2020 •
edited
Loading

unittest-expander has some old code which will likely break on Python 3.8 zuo/unittest_expander#1

http://github.com/maaku/scenariotest/ might be a suitable replacement.

upstream rules checker also has some bad regex EFForg/https-everywhere#18985
@jayvdb
Copy link
Owner Author

jayvdb commented Feb 26, 2020

There is a chunk of code here in _unregex.py:127 that is incompatible with py38

>       new = sre_parse.SubPattern(pattern.pattern)
E       AttributeError: 'SubPattern' object has no attribute 'pattern'

jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
split_regex: Disable remainder on Python 3.8
aee38c3 
This isnt compatible with Python 3.8 and is unnecessary.

Fixes #15
@jayvdb jayvdb closed this as completed in ea0e168 Feb 26, 2020
@jayvdb jayvdb self-assigned this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb