snapshot: collect data related to GPU devices #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
split from #235 |
jaypipes
requested changes
May 11, 2021
make sure the snapshot code collects data related to GPU devices. Turns out not much was missing, most notably the `/sys/class/drm` link; nevertheless, let's make sure to collect this data, so now also the gpu package can consume snapshots. We choose to refactor the code from net devices collection more for clarity -what we collect and what we filter out is a bit more explicit now- than to avoid duplication. The PCI collection code is a bit more elaborate, because it needs to deal with PCI roots and subtrees (subforests?), so it was intentionally left out for the time being. Signed-off-by: Francesco Romani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the snapshot code collects data related to GPU devices.
Turns out not much was missing, most notably the
/sys/class/drmlink;nevertheless, let's make sure to collect this data, so now also the
gpu package can consume snapshots.
We choose to refactor the code from net devices collection more
for clarity -what we collect and what we filter out is a bit more
explicit now- than to avoid duplication.
The PCI collection code is a bit more elaborate, because it needs to
deal with PCI roots and subtrees (subforests?), so it was intentionally
left out for the time being.
Signed-off-by: Francesco Romani [email protected]