Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create turkish.json #196

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Create turkish.json #196

merged 4 commits into from
Jan 20, 2021

Conversation

dogagcmnr
Copy link
Contributor

Will continue tomorrow

Wasn't a productive day. 

It does not matter how slowly you go as long as you do not stop.
-Confucius
"translation": "blanket"
},
{
"word": kör",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far -- it seems like you are missing a quotation mark here which is why Github registers the JSON as invalid. You can use JSONlint to validate if your JSON is correct.

Let me know if this PR is up for review already :)

@jayehernandez
Copy link
Owner

Hey @dogagcmnr, just checking up on this, is this ready to go? :)

@dogagcmnr
Copy link
Contributor Author

Hey @dogagcmnr, just checking up on this, is this ready to go? :)

Hey @jayehernandez, i'm going to inform you asap.

All done, checked and validated!
I was waiting for my new setup so I can write a Python script that would do the job for me.
Anyone who reads this I hope it can be some kind of inspiration for coding to make your life easier.
Feel free to check it in my repo 😄 👍 
Have a great day!
Copy link
Contributor Author

@dogagcmnr dogagcmnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Please approve it @jayehernandez 👍

@jayehernandez
Copy link
Owner

Hey @dogagcmnr thank you so much for your contribution! The start of the year got quite hectic for me so I wasn't able to merge this earlier. Good work though, I'll be including this in the next release 🥳

@jayehernandez jayehernandez merged commit 33b0832 into jayehernandez:master Jan 20, 2021
@jayehernandez
Copy link
Owner

@all-contributors please add @dogagcmnr for translation

@allcontributors
Copy link
Contributor

@jayehernandez

I've put up a pull request to add @dogagcmnr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants