[PHP] Bugfix: DateTime object on query (OpenAPITools#13583)

* [PHP] BUGFIX: fix code breaking when query params contain a DateTime object * [PHP] Autogenerated files
jayandran-Sampath · Oct 6, 2022 · ef44271 · ef44271
1 parent 8a1d445
commit ef44271
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache b/modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache
@@ -180,6 +180,11 @@ class ObjectSerializer
             }
         }
 
+        # Handle DateTime objects in query
+        if($openApiType === "\\DateTime" && $value instanceof \DateTime) {
+            return ["{$paramName}" => $value->format(self::$dateTimeFormat)];
+        }
+
         $query = [];
         $value = (in_array($openApiType, ['object', 'array'], true)) ? (array)$value : $value;
 

diff --git a/samples/client/petstore/php/OpenAPIClient-php/lib/ObjectSerializer.php b/samples/client/petstore/php/OpenAPIClient-php/lib/ObjectSerializer.php
@@ -189,6 +189,11 @@ public static function toQueryValue(
             }
         }
 
+        # Handle DateTime objects in query
+        if($openApiType === "\\DateTime" && $value instanceof \DateTime) {
+            return ["{$paramName}" => $value->format(self::$dateTimeFormat)];
+        }
+
         $query = [];
         $value = (in_array($openApiType, ['object', 'array'], true)) ? (array)$value : $value;
 

diff --git a/samples/client/petstore/php/OpenAPIClient-php/tests/ObjectSerializerTest.php b/samples/client/petstore/php/OpenAPIClient-php/tests/ObjectSerializerTest.php
@@ -327,6 +327,15 @@ public function provideQueryParams(): array
                 true,
                 'filter%5Bor%5D%5B0%5D%5Bname%5D=John&filter%5Bor%5D%5B1%5D%5Bemail%5D=john%40doe.com'
             ],
+            'form DateTime object, explode on, required true' => [
+                new DateTime('2021-10-06T20:17:16'), 'dateTime', '\DateTime', 'form', true, true, 'dateTime=2021-10-06T20%3A17%3A16%2B00%3A00',
+            ],
+            'form null DateTime object, explode on, required true' => [
+                null, 'dateTime', '\DateTime', 'form', true, true, 'dateTime=',
+            ],
+            'form null DateTime object, explode on, required false' => [
+                null, 'dateTime', '\DateTime', 'form', true, false, '',
+            ],
         ];
     }