❇️ Improve chunk extraction with multi-byte string #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt
Ousret
added
bug
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 85.25% 85.54% +0.29%
==========================================
Files 11 11
Lines 1187 1197 +10
==========================================
+ Hits 1012 1024 +12
+ Misses 175 173 -2
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt following draft #90
Abstract
When
charset_normalizermeasure the mess/coherence in a given byte sequence for a given encoding, it extract small chunks of data.Sometime, due to bad luck, it could split the data at the wrong initial index causing the rendered str (for the chunk) to be gibberish.
This PR address that problem and try to find the appropriate start index.