Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated testing with Mocha #63

Merged
merged 17 commits into from
Mar 6, 2020
Merged

Automated testing with Mocha #63

merged 17 commits into from
Mar 6, 2020

Conversation

alexgalkin
Copy link
Contributor

Translation for "Automated testing with Mocha" section.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 5, 2020 23:48
tarasyyyk
tarasyyyk requested changes Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чудова робота! Поправте деякі зауваження перед злиттям в основну гілку.

1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/05-testing-mocha/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakan iliakan mentioned this pull request Mar 6, 2020
Open
alexgalkin and others added 7 commits March 6, 2020 23:46
@alexgalkin alexgalkin requested a review from tarasyyyk March 6, 2020 21:48
@alexgalkin
Copy link
Contributor Author

/done

@tarasyyyk thanks for your attention.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 6, 2020 21:49
tarasyyyk
tarasyyyk approved these changes Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! PR will be merged now.

@tarasyyyk tarasyyyk merged commit a105561 into javascript-tutorial:master Mar 6, 2020
@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title Translation for "Automated testing with Mocha" section Automated testing with Mocha Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgalkin @javascript-translate-bot @tarasyyyk