Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpf-nhandler's tests are failing on amd based machines #12

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

Harsh4902
Copy link
Contributor

@Harsh4902
Copy link
Contributor Author

Harsh4902 commented Jul 10, 2024

@cyrille-artho can you please try this change at your local machine. I have checked this, and it's working for both of my intel based machine and m1 mac.

@cyrille-artho
Copy link
Member

Good job! It looks like this is a major improvement, but there is at least one more step needed.

Works on one machine (Ubuntu 22), fails on another (Ubuntu 20).
On the CI build, we have one failure:

converter.specific.JPF2JVMjava_utilTest > convertRandomTest FAILED
    java.lang.AssertionError at JPF2JVMjava_utilTest.java:47

I think if you can get that case to pass, we can continue from there. If the CI build passes, we have at least one reference platform with Linux where the build is successful.

@Harsh4902
Copy link
Contributor Author

@cyrille-artho Yes, I am trying to run it on Ubuntu 20.

@cyrille-artho
Copy link
Member

I now have one test failing on an Ubuntu 22 machine that I have access to, and still all tests failing on Ubuntu 20.
The CI build (hosted by GitHub) is a success, though. Mac OS X also works.
@pparizek , can you please try this build, too, and see if it works for you?

@Harsh4902
Copy link
Contributor Author

I have tested on Ubuntu 20, 22 and macOS. Tests are passed on all the machines.

@cyrille-artho cyrille-artho merged commit 169fa29 into javapathfinder:master Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jpf-nhandler's tests are failing on amd based machines
2 participants