New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use slug for team name #134

Merged

h13i32maru merged 1 commit into jasperapp:master from mtgto:fix_team_name

Jun 30, 2020

Contributor

mtgto commented Jun 30, 2020

It should use team.slug instead of team.name.

GitHub API uses the team's slug as parameter, which is generated by team's name.
ex. https://developer.github.com/v3/teams/#get-a-team-by-name

For instance, Jasper recognize team name as "foo/bar@baz" if team name is "foo/bar@baz".
But github creates slug as "bar-baz".


          fix(SystemTeamStream) use slug for team name

8703d91

h13i32maru merged commit ace1aea into jasperapp:master

Member

h13i32maru commented Jun 30, 2020

👍

mtgto deleted the fix_team_name branch

July 1, 2020 01:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet