Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass qgraph object rather than function #3121

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

vandenman
Copy link
Contributor

Should fix the recurring network bug on windows.

@vandenman vandenman requested a review from TimKDJ March 20, 2019 15:10
@TimKDJ
Copy link
Contributor

TimKDJ commented Mar 20, 2019

Fixes jasp-stats/jasp-issues#158, jasp-stats/jasp-issues#229, jasp-stats/jasp-issues#264 and possibly jasp-stats/jasp-issues#306

For future reference, the problem is as follows:
The network analysis plot is a qgraph object but we passed this to writeimage() as a function, which in turn transformed it to a recordedPlot and this recordedPlot was saved in the state. At the moment of retrieving this state the recordedPlot's complexity was apparently too great for R's load() and so R crashed. The condition was not caught by R and therefore the tryCatch() did nothing, which is why it appeared as a hard crash in JASP. To fix this we pass writeimage() the qgraph object and consequently this is also what goes in the state.

Not really sure what causes the difference between loading the state in the JASP context vs interactive R; or mac vs windows, but it appears solved now.

@AlexanderLyNL AlexanderLyNL merged commit d45f7ff into jasp-stats:development Mar 20, 2019
@vandenman vandenman deleted the networkfix branch July 13, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants