Tweak VoiceCraft x HF integration #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tweaks the HF integrations: - `VoiceCraft` tag is lowercased to `voicecraft` => not a hard requirement but makes it more consistent with other libraries on the Hub. - `voicecraft` is set as the `library_name` instead of simply a tag. This is better for taxonomy on the Hub. Regarding the integration, I also opened huggingface/huggingface.js#626 to make it more official on the Hub. In particular, there will now be an official `</> Use in VoiceCraft` button in all voicecraft models that display the code snippet to load the model. This should help users getting started with the model. It will also add a link to the voicecraft repo for the installation guide. cc @NielsRogge who opened jasonppy#78
julien-c
reviewed
Apr 15, 2024
Co-authored-by: Julien Chaumond <[email protected]>
Wauplin
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Apr 16, 2024
Related to #626. See #626 (comment) for more context. This PR update the voicecraft code snippet to switch from `VoiceCraftHF` class to `VoiceCraft`. PR jasonppy/VoiceCraft#90 must be merged to make this snippet work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the HF integrations:
VoiceCrafttag is lowercased tovoicecraft=> not a hard requirement but makes it more consistent with other libraries on the Hub.voicecraftis set as thelibrary_nameinstead of simply a tag. This is better for taxonomy on the Hub.Text-to-Speechis lowercased to be recognized as a task by the HF HubVoiceCraftHFclass has been removed to have a singleVoiceCraft. Requires a small update at init (see e550f61) but it'll make the process much smoother for end users. With this change, it'll be possible for users to retrain aVoiceCraftobject and push it to the Hub withVoiceCraft(...).push_to_hub(...)which was not the case before.Regarding the integration, I also opened huggingface/huggingface.js#626 to make it more official on the Hub. In particular, there will now be an official
</> Use in VoiceCraftbutton in all voicecraft models that display the code snippet to load the model. This should help users getting started with the model. It will also add a link to the voicecraft repo for the installation guide.cc @NielsRogge who opened #78
EDIT: I also opened PR on existing models to reflect these changes.