fs: properly handle fd passed to truncate()

Currently, fs.truncate() silently fails when a file descriptor is passed as the first argument. This commit changes this behavior to properly call fs.ftruncate(). This commit also adds proper type checking to the callback provided to makeCallback(). PR-URL: nodejs#9161 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy J Fontaine <[email protected]>
jasnell · Mar 14, 2015 · 16b8aca · 16b8aca
1 parent 8727042
commit 16b8aca
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -87,10 +87,14 @@ function maybeCallback(cb) {
 // for callbacks that are passed to the binding layer, callbacks that are
 // invoked from JS already run in the proper scope.
 function makeCallback(cb) {
-  if (!util.isFunction(cb)) {
+  if (util.isNullOrUndefined(cb)) {
     return rethrow();
   }
 
+  if (!util.isFunction(cb)) {
+    throw new TypeError('callback must be a function');
+  }
+
   return function() {
     return cb.apply(null, arguments);
   };