Skip to content

Commit

Permalink
Parallel: take care of pending specs
Browse files Browse the repository at this point in the history
  • Loading branch information
sgravrock committed Apr 28, 2023
1 parent 2d8ff6c commit 0fc3a2d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 11 deletions.
4 changes: 0 additions & 4 deletions spec/command_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -502,10 +502,6 @@ describe('command', function() {
});

sharedRunBehavior('--parallel=2');

it('does not allow the random seed to be set');

it('does not allow randomization to be disabled');
});
});

Expand Down
3 changes: 0 additions & 3 deletions spec/parallel_runner_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,6 @@ describe('ParallelRunner', function() {
});
});

it('handles worker crashes');
it('handles worker exec failures');

it('dispatches a jasmineStarted event at the start of execution', async function () {
this.testJasmine.numWorkers = 2;
this.testJasmine.loadConfig({
Expand Down
29 changes: 25 additions & 4 deletions spec/parallel_worker_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,31 @@ describe('ParallelWorker', function() {
expect(core.boot).toHaveBeenCalledWith(jasmine.is(core));
});

it('does something reasonable when the core module fails to load');
it('sends a fatalError message when the core module fails to load', async function() {
const error = new Error('core loading failed');
const loader = {
load() {
return Promise.reject(error);
}
};
new ParallelWorker({loader, clusterWorker: this.clusterWorker});

this.clusterWorker.emit('message', {
type: 'configure',
configuration: {}
});
await new Promise(res => setTimeout(res));

expect(this.clusterWorker.send).toHaveBeenCalledWith(
{
type: 'fatalError',
error: {
message: error.message,
stack: error.stack
},
}
);
});

it('creates and configures an env', async function() {
const env = jasmine.createSpyObj('env', [
Expand Down Expand Up @@ -555,9 +579,6 @@ describe('ParallelWorker', function() {
});
}
});


it('exits on disconnect');
});

function dispatchRepoterEvent(env, eventName, payload) {
Expand Down

0 comments on commit 0fc3a2d

Please sign in to comment.