Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasmine-browser-runner do not support absolute paths for src and spec dirs #15

Closed
marianobntz-silohub opened this issue Mar 18, 2022 · 3 comments · Fixed by #50
Closed

Comments

@marianobntz-silohub
Copy link

I spent quite some time figuring out why my tests were not found in the runner, I discovered that srcDir and specDir are joined with the project baseDir when finding the files...

In the server.js file, the userJs method, it uses getUrl that will always join this.projectBaseDir with the arguments...

It breaks when I pass absolute paths in the config file.

Would be nice to support them.
Thanks

@sgravrock
Copy link
Member

I'd be happy to review a PR that stops the base dir from being prepended to paths that are already absolute. In the meantime, you should probably be able to make it work by setting projectBaseDir to "/", at least if you're not on Windows.

@marianobntz-silohub
Copy link
Author

I'd be happy to review a PR that stops the base dir from being prepended to paths that are already absolute. In the meantime, you should probably be able to make it work by setting projectBaseDir to "/", at least if you're not on Windows.

Nope, that is why posted the issue, it does not work with "/" at the beginning of the path.

@joeyparrish
Copy link
Contributor

I have a fix for this. I'll post a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants