don't mutate locationData

jashkenas · Oct 8, 2018 · 51f566f · 51f566f
1 parent b3d5cdb
commit 51f566f
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 18 deletions.
diff --git a/lib/coffeescript/nodes.js b/lib/coffeescript/nodes.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -1305,20 +1305,24 @@ exports.Call = class Call extends Base
   # expands the range on the left, but not the right.
   updateLocationDataIfMissing: (locationData) ->
     if @locationData and @needsUpdatedStartLocation
-      @locationData.first_line = locationData.first_line
-      @locationData.first_column = locationData.first_column
-      @locationData.range = [
-        locationData.range[0]
-        @locationData.range[1]
-      ]
-      base = @variable?.base or @variable
-      if base.needsUpdatedStartLocation
-        @variable.locationData.first_line = locationData.first_line
-        @variable.locationData.first_column = locationData.first_column
-        @variable.locationData.range = [
+      @locationData = Object.assign {},
+        @locationData,
+        first_line: locationData.first_line
+        first_column: locationData.first_column
+        range: [
           locationData.range[0]
-          @variable.locationData.range[1]
+          @locationData.range[1]
         ]
+      base = @variable?.base or @variable
+      if base.needsUpdatedStartLocation
+        @variable.locationData = Object.assign {},
+          @variable.locationData,
+          first_line: locationData.first_line
+          first_column: locationData.first_column
+          range: [
+            locationData.range[0]
+            @variable.locationData.range[1]
+          ]
         base.updateLocationDataIfMissing locationData
       delete @needsUpdatedStartLocation
     super locationData