Add Backbone.Class #2413
Closed
Add Backbone.Class #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew, Collection, Router and History can extend from.
|
So I just saw #276. Probably should have searched before submitting this. I'm assuming thoughts haven't changed regarding adding a base class, but I still think something like this would add value without deviating from the core pupose of Backbone. |
| @@ -933,7 +972,7 @@ | |||
| this.trigger.apply(this, arguments); | |||
| } | |||
|
|
|||
| }); | |||
| }) | |||
Yes, and yes ;) |
|
Any thoughts on this being accepted as a simple refactor (if Backbone.Class wasn't exposed publicly) - seems cleaner and is -3 loc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the extend method and mixes in Events so it can be used to create simple objects that don't need the extra functionality in Model, View, etc.
I've made Model, View, Collection, Router, and History subclasses of this base object to collect this logic in one place. It also seems like this should be easier to follow for people who are already familiar with Backbone's inheritance pattern.